Fixed bug in exponential retry intervals (#83)

* Fixed bug in exponential retry intervals

* Update test.yml

Author: britzl

.github/workflows/test.yml

@@ -10,10 +10,8 @@ jobs:
     - uses: actions/checkout@v3
       name: Checkout project
 
-    - uses: leafo/gh-actions-lua@v9
-      name: Install Lua
-      with:
-        luaVersion: "5.1.5"
+    - name: Install Lua
+      run: sudo apt-get install lua5.1 lua-check luarocks
 
     - name: Setup telescope
       run: |
@@ -28,4 +26,4 @@ jobs:
     - name: Run tests
       run: |
         lua -v
-        ./tsc -f test/test_socket.lua test/test_nakama.lua test/test_satori.lua test/test_session.lua
+        ./tsc -f test/test_socket.lua test/test_nakama.lua test/test_satori.lua test/test_session.lua test/test_retries.lua

CHANGELOG.md

@@ -7,7 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+- Creating an exponentially increasing retry interval caused a Lua error
+
 ## [3.4.0] - 2024-09-16
+### Added
 - Added support for Satori
 
 ## [3.3.0] - 2024-06-14

nakama/util/retries.lua

@@ -9,7 +9,7 @@ local M = {}
 function M.exponential(attempts, interval)
 	local delays = {}
 	for i=1,attempts do
-		delays[i] = (i > 1) and delays[i] * 2 or interval
+		delays[i] = (i > 1) and delays[i - 1] * 2 or interval
 	end
 	return delays
 end

test/test_retries.lua

@@ -0,0 +1,52 @@
+local retries = require "nakama.util.retries"
+local log = require "nakama.util.log"
+log.print()
+
+context("Retries", function()
+
+	before(function() end)
+	after(function() end)
+
+	test("create exponentially increasing intervals", function()
+		local intervals = retries.exponential(5, 0.5)
+		assert(#intervals == 5)
+		assert(intervals[1] == 0.5)
+		assert(intervals[2] == 1.0)
+		assert(intervals[3] == 2.0)
+		assert(intervals[4] == 4.0)
+		assert(intervals[5] == 8.0)
+	end)
+
+	test("create incrementally increasing intervals", function()
+		local intervals = retries.incremental(5, 0.5)
+		assert(#intervals == 5)
+		assert(intervals[1] == 0.5)
+		assert(intervals[2] == 1.0)
+		assert(intervals[3] == 1.5)
+		assert(intervals[4] == 2.0)
+		assert(intervals[5] == 2.5)
+	end)
+
+	test("create fixed intervals", function()
+		local intervals = retries.fixed(5, 0.5)
+		assert(#intervals == 5)
+		assert(intervals[1] == 0.5)
+		assert(intervals[2] == 0.5)
+		assert(intervals[3] == 0.5)
+		assert(intervals[4] == 0.5)
+		assert(intervals[5] == 0.5)
+	end)
+
+	test("create no intervals", function()
+		local intervals = retries.none()
+		assert(#intervals == 0)
+		intervals = retries.exponential(0, 0)
+		assert(#intervals == 0)
+		intervals = retries.incremental(0, 0)
+		assert(#intervals == 0)
+		intervals = retries.fixed(0, 0)
+		assert(#intervals == 0)
+	end)
+end)
+
+