Error cleanup (#1080)

* Error cleanup

Found a couple of mistakes in the error messages that needed to be corrected.

Author: colincasey

buildpacks/nodejs-npm-engine/src/errors.rs

@@ -114,7 +114,7 @@ fn on_npm_install_error(error: NpmInstallError) -> ErrorMessage {
 
         NpmInstallError::OpenTarball(path, e) => error_message()
             .error_type(UserFacing(SuggestRetryBuild::Yes, SuggestSubmitIssue::Yes))
-            .header(format!("Failed to opening the downloaded {npm} package file"))
+            .header(format!("Failed to open the downloaded {npm} package file"))
             .body(formatdoc! {"
                 An unexpected I/O occurred while opening the downloaded {npm} package file at {path}.
             ", path = file_value(path) })
@@ -125,7 +125,7 @@ fn on_npm_install_error(error: NpmInstallError) -> ErrorMessage {
             .error_type(UserFacing(SuggestRetryBuild::Yes, SuggestSubmitIssue::Yes))
             .header(format!("Failed to extract {npm} package file"))
             .body(formatdoc! {"
-                An unexpected I/O occurred while extracing the contents of the downloaded {npm} package file at {path}.
+                An unexpected I/O occurred while extracting the contents of the downloaded {npm} package file at {path}.
             ", path = file_value(path) })
             .debug_info(e.to_string())
             .create(),

buildpacks/nodejs-npm-engine/src/snapshots/errors___npm_engine_npm_install_decompress_tarball_error.snap

@@ -6,7 +6,7 @@ source: buildpacks/nodejs-npm-engine/src/errors.rs
 
 ! Failed to extract `npm` package file
 !
-! An unexpected I/O occurred while extracing the contents of the downloaded `npm` package file at `/layers/npm/install/npm.tgz`.
+! An unexpected I/O occurred while extracting the contents of the downloaded `npm` package file at `/layers/npm/install/npm.tgz`.
 !
 ! Use the debug information above to troubleshoot and retry your build.
 !

buildpacks/nodejs-npm-engine/src/snapshots/errors___npm_engine_npm_install_open_tarball_error.snap

@@ -4,7 +4,7 @@ source: buildpacks/nodejs-npm-engine/src/errors.rs
 - Debug Info:
   - Invalid permissions
 
-! Failed to opening the downloaded `npm` package file
+! Failed to open the downloaded `npm` package file
 !
 ! An unexpected I/O occurred while opening the downloaded `npm` package file at `/layers/npm/install/npm.tgz`.
 !

buildpacks/nodejs-npm-install/src/errors.rs

@@ -49,15 +49,17 @@ fn on_buildpack_error(error: NpmInstallBuildpackError) -> ErrorMessage {
 fn on_node_build_scripts_metadata_error(error: NodeBuildScriptsMetadataError) -> ErrorMessage {
     let NodeBuildScriptsMetadataError::InvalidEnabledValue(value) = error;
     let value_type = value.type_str();
+    let requires_metadata = style::value("[requires.metadata]");
+    let buildplan_name = style::value(NODE_BUILD_SCRIPTS_BUILD_PLAN_NAME);
     error_message()
         .error_type(ErrorType::UserFacing(
             SuggestRetryBuild::No,
             SuggestSubmitIssue::Yes,
         ))
-        .header("Invalid build script metadata")
+        .header("Invalid build plan metadata")
         .body(formatdoc! { "
-            A participating buildpack has set invalid `[requires.metadata]` for the build plan \
-            named `{NODE_BUILD_SCRIPTS_BUILD_PLAN_NAME}`.
+            A participating buildpack has set invalid {requires_metadata} for the build plan \
+            named {buildplan_name}.
             
             Expected metadata format:
             [requires.metadata]

buildpacks/nodejs-npm-install/src/main.rs

@@ -112,7 +112,7 @@ impl Buildpack for NpmInstallBuildpack {
 
     fn on_error(&self, error: libcnb::Error<Self::Error>) {
         let error_message = errors::on_error(error);
-        eprintln!("{error_message}");
+        eprintln!("\n{error_message}");
     }
 }
 

buildpacks/nodejs-npm-install/src/snapshots/errors___npm_install_node_build_scripts_metadata_error.snap

@@ -1,7 +1,7 @@
 ---
 source: buildpacks/nodejs-npm-install/src/errors.rs
 ---
-! Invalid build script metadata
+! Invalid build plan metadata
 !
 ! A participating buildpack has set invalid `[requires.metadata]` for the build plan named `node_build_scripts`.
 !