Skip to content

Commit ec87b20

Browse files
committed
Fix typos in error messages and comments
- `s/can longer/can no longer/` - `s/due an issue/due to an issue/` - `s/mange.py/manage.py/` etc
1 parent 83cba6f commit ec87b20

8 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/django.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ fn has_collectstatic_command(app_dir: &Path, env: &Env) -> Result<bool, Captured
7171
.map_or_else(
7272
|error| match error {
7373
// We need to differentiate between the command not existing (due to the staticfiles app
74-
// not being installed) and the Django config or mange.py script being broken. Ideally
74+
// not being installed) and the Django config or manage.py script being broken. Ideally
7575
// we'd inspect the output of `manage.py help --commands` but that command unhelpfully
7676
// exits zero even if the app's `DJANGO_SETTINGS_MODULE` wasn't a valid module.
7777
// Note: Django incorrectly outputs "Unknown command" if the Django config is invalid

src/errors.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ fn on_requested_python_version_error(error: RequestedPythonVersionError) {
235235
PackageManager::Uv => log_error(
236236
"The runtime.txt file isn't supported",
237237
formatdoc! {"
238-
The runtime.txt file can longer be used, since it has been
238+
The runtime.txt file can no longer be used, since it has been
239239
replaced by the more widely supported .python-version file.
240240
241241
Please switch to a .python-version file instead:
@@ -254,7 +254,7 @@ fn on_requested_python_version_error(error: RequestedPythonVersionError) {
254254
_ => log_error(
255255
"The runtime.txt file isn't supported",
256256
formatdoc! {"
257-
The runtime.txt file can longer be used, since it has been
257+
The runtime.txt file can no longer be used, since it has been
258258
replaced by the more widely supported .python-version file.
259259
260260
Please delete your runtime.txt file and create a new file named:
@@ -609,7 +609,7 @@ fn on_django_collectstatic_error(error: DjangoCollectstaticError) {
609609
The 'python manage.py collectstatic --noinput' Django management
610610
command to generate static files failed ({exit_status}).
611611
612-
This is most likely due an issue in your application code or Django
612+
This is most likely due to an issue in your application code or Django
613613
configuration. See the log output above for more information.
614614
615615
If you are using the WhiteNoise package to optimize the serving of static

src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ impl Buildpack for PythonBuildpack {
6363
// We inherit the current process's env vars, since we want `PATH` and `HOME` from the OS
6464
// to be set (so that later commands can find tools like Git in the base image), along
6565
// with previous-buildpack or user-provided env vars (so that features like env vars in
66-
// in requirements files work). We protect against broken user-provided env vars via the
66+
// requirements files work). We protect against broken user-provided env vars via the
6767
// checks feature and making sure that buildpack env vars take precedence in layers envs.
6868
let mut env = Env::from_current();
6969

src/utils.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ pub(crate) struct FindBundledPipError {
192192
}
193193

194194
/// A helper for running an external process using [`Command`], that streams stdout/stderr
195-
/// to the user and checks that the exit status of the process was non-zero.
195+
/// to the user and checks that the exit status of the process was zero.
196196
pub(crate) fn run_command_and_stream_output(
197197
command: &mut Command,
198198
) -> Result<(), StreamedCommandError> {
@@ -214,7 +214,7 @@ pub(crate) fn run_command_and_stream_output(
214214
}
215215

216216
/// A helper for running an external process using [`Command`], that captures stdout/stderr
217-
/// and checks that the exit status of the process was non-zero.
217+
/// and checks that the exit status of the process was zero.
218218
pub(crate) fn run_command_and_capture_output(
219219
command: &mut Command,
220220
) -> Result<Output, CapturedCommandError> {

tests/django_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ fn django_staticfiles_misconfigured() {
196196
The 'python manage.py collectstatic --noinput' Django management
197197
command to generate static files failed (exit status: 1).
198198
199-
This is most likely due an issue in your application code or Django
199+
This is most likely due to an issue in your application code or Django
200200
configuration. See the log output above for more information.
201201
202202
If you are using the WhiteNoise package to optimize the serving of static

tests/poetry_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ fn poetry_editable_git_compiled() {
228228

229229
// This checks that the Poetry bootstrap works even with older bundled pip, and that our chosen
230230
// Poetry version also supports our oldest supported Python version. The fixture also includes
231-
// a `brotli` directory to the buildpack isn't affected by an `ensurepip` bug in older Python
232-
// versions: https://github.com/heroku/heroku-buildpack-python/issues/1697
231+
// a `brotli` directory to confirm the buildpack isn't affected by an `ensurepip` bug in older
232+
// Python versions: https://github.com/heroku/heroku-buildpack-python/issues/1697
233233
#[test]
234234
#[ignore = "integration test"]
235235
fn poetry_oldest_python() {

tests/python_version_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ fn runtime_txt() {
399399
[Determining Python version]
400400
401401
[Error: The runtime.txt file isn't supported]
402-
The runtime.txt file can longer be used, since it has been
402+
The runtime.txt file can no longer be used, since it has been
403403
replaced by the more widely supported .python-version file.
404404
405405
Please delete your runtime.txt file and create a new file named:
@@ -440,7 +440,7 @@ fn runtime_txt_invalid_version() {
440440
[Determining Python version]
441441
442442
[Error: The runtime.txt file isn't supported]
443-
The runtime.txt file can longer be used, since it has been
443+
The runtime.txt file can no longer be used, since it has been
444444
replaced by the more widely supported .python-version file.
445445
446446
Please delete your runtime.txt file and create a new file named:

tests/uv_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ fn uv_runtime_txt() {
338338
[Determining Python version]
339339
340340
[Error: The runtime.txt file isn't supported]
341-
The runtime.txt file can longer be used, since it has been
341+
The runtime.txt file can no longer be used, since it has been
342342
replaced by the more widely supported .python-version file.
343343
344344
Please switch to a .python-version file instead:

0 commit comments

Comments
 (0)