fix: make heroku data env var override redis host too. (#3239)

* Make HEROKU_DATA_HOST override redis host too

* change all heroku data services to only use HEROKU_DATA_HOST custom env var

* Make pg host and redis host the same

Co-authored-by: Justin Downing <jdowning@heroku.com>

* make pg host same as redis host

* Update host based on pr feedback

---------

Co-authored-by: Justin Downing <jdowning@heroku.com>
Co-authored-by: Matt Blewitt <118200221+mble-sfdc@users.noreply.github.com>
Co-authored-by: Zane Whitfield <zwhitfield@salesforce.com>

Author: 4 people

packages/cli/src/lib/pg/host.ts

@@ -1,4 +1,3 @@
 export default function () {
-  const host = process.env.HEROKU_DATA_HOST || process.env.HEROKU_POSTGRESQL_HOST
-  return host ? host : 'api.data.heroku.com'
+  return process.env.HEROKU_DATA_HOST || 'api.data.heroku.com'
 }

packages/cli/src/lib/redis/api.ts

@@ -66,7 +66,7 @@ export type RedisFormationWaitResponse = {
 type HttpVerb = 'GET' | 'POST' | 'PATCH' | 'DELETE' | 'PUT'
 
 export default (app: string, database: string | undefined, json: boolean, heroku: APIClient) => {
-  const HOST = process.env.HEROKU_REDIS_HOST || 'api.data.heroku.com'
+  const HOST = process.env.HEROKU_DATA_HOST || process.env.HEROKU_REDIS_HOST || 'api.data.heroku.com'
   const ADDON = process.env.HEROKU_REDIS_ADDON_NAME || 'heroku-redis'
 
   return {