refactor: apply lint formatting to scripts and hooks folders (#3669)

* refactor: rename script files to kebab-case convention

Renames files from underscore to hyphen naming:
- scripts/postrelease/install_scripts.js → install-scripts.js
- scripts/utils/_version.js → version.js

This aligns with the project's file naming standards.

* refactor: apply lint formatting to scripts and hooks folders

Applies ESLint formatting fixes to scripts and hooks folders:
- Reorder imports to follow style guide (node: prefixed imports first, then external, then internal)
- Use node: prefix for Node.js built-in modules (node:path, node:child_process, etc.)
- Change from `import * as` to default imports where appropriate
- Add proper error handling with try-catch blocks in postrelease scripts
- Remove unnecessary semicolons and apply consistent formatting

This brings the scripts and hooks folders in line with the shared ESLint configuration.

Author: eablack

scripts/postrelease/install-scripts.js

@@ -0,0 +1,40 @@
+#!/usr/bin/env node
+
+import execa from 'execa'
+import path from 'node:path'
+import {fileURLToPath} from 'node:url'
+import qq from 'qqjs'
+
+import getHerokuS3Bucket from '../utils/get-heroku-s3-bucket.js'
+import isStableRelease from '../utils/is-stable-release.js'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+
+const opts = {
+  cwd: path.join(__dirname, '..', '..'),
+  stdio: 'inherit',
+}
+
+qq.config.silent = false
+
+try {
+  await qq.run(async () => {
+    const {GITHUB_REF_NAME, GITHUB_REF_TYPE} = process.env
+
+    if (isStableRelease(GITHUB_REF_TYPE, GITHUB_REF_NAME)) {
+      const HEROKU_S3_BUCKET = await getHerokuS3Bucket()
+      await execa.command(`aws s3 cp --content-type text/plain --cache-control max-age=604800 ./install-standalone.sh s3://${HEROKU_S3_BUCKET}/install-standalone.sh`, opts)
+      await execa.command(`aws s3 cp --content-type text/plain --cache-control max-age=604800 ./install-standalone.sh s3://${HEROKU_S3_BUCKET}/install.sh`, opts)
+      await execa.command(`aws s3 cp --content-type text/plain --cache-control max-age=604800 ./install-ubuntu.sh s3://${HEROKU_S3_BUCKET}/install-ubuntu.sh`, opts)
+    } else {
+      console.log('Not on stable release, skipping updating install scripts')
+      // eslint-disable-next-line n/no-process-exit
+      process.exit(0)
+    }
+  })
+} catch (error) {
+  console.error(error)
+  // eslint-disable-next-line n/no-process-exit
+  process.exit(1)
+}

scripts/postrelease/install_scripts.js

@@ -1,23 +1,25 @@
-import fs from 'fs'
 import execa from 'execa'
-import path from 'path'
-import { fileURLToPath } from 'url'
-import { rimrafSync } from 'rimraf'
-import { promisify } from 'util'
-import { pipeline } from 'stream'
-import crypto from 'crypto'
+import crypto from 'node:crypto'
+import fs from 'node:fs'
+import path from 'node:path'
+import {pipeline} from 'node:stream'
+import {fileURLToPath} from 'node:url'
+import {promisify} from 'node:util'
+import {rimrafSync} from 'rimraf'
+
 import getHerokuS3Bucket from '../utils/get-heroku-s3-bucket.js'
 import isStableRelease from '../utils/is-stable-release.js'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
-const {GITHUB_SHA_SHORT, GITHUB_REF_TYPE, GITHUB_REF_NAME} = process.env
-const packageJson = JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json'), 'utf-8'))
+const {GITHUB_REF_NAME, GITHUB_REF_TYPE, GITHUB_SHA_SHORT} = process.env
+const packageJson = JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json'), 'utf8'))
 const VERSION = packageJson.version
 
 if (!isStableRelease(GITHUB_REF_TYPE, GITHUB_REF_NAME)) {
   console.log('Not on stable release; skipping releasing homebrew')
+  // eslint-disable-next-line n/no-process-exit, unicorn/no-process-exit
   process.exit(0)
 }
 
@@ -44,7 +46,7 @@ function downloadFileFromS3(s3Path, fileName, downloadPath) {
 
 async function updateHerokuFormula(brewDir) {
   const templatePath = path.join(TEMPLATES, 'heroku.rb')
-  const template = fs.readFileSync(templatePath).toString('utf-8')
+  const template = fs.readFileSync(templatePath).toString('utf8')
   const formulaPath = path.join(brewDir, 'Formula', 'heroku.rb')
 
   const fileNamePrefix = `heroku-v${VERSION}-${GITHUB_SHA_SHORT}`
@@ -69,8 +71,8 @@ async function updateHerokuFormula(brewDir) {
   const sha256LinuxIntel = await calculateSHA256(path.join(__dirname, fileNameLinuxIntel))
   const sha256LinuxArm = await calculateSHA256(path.join(__dirname, fileNameLinuxArm))
 
-  const templateReplaced =
-    template
+  const templateReplaced
+    = template
       .replace('__CLI_VERSION__', VERSION)
 
       .replace('__CLI_MAC_INTEL_DOWNLOAD_URL__', `${urlPrefix}/${fileNameMacIntel}`)
@@ -106,7 +108,8 @@ async function updateHomebrew() {
   await setupGit()
 
   console.log(`cloning https://github.com/heroku/homebrew-brew to ${homebrewDir}`)
-  await execa('git',
+  await execa(
+    'git',
     [
       'clone',
       'git@github.com:heroku/homebrew-brew.git',
@@ -132,7 +135,10 @@ async function updateHomebrew() {
   }
 }
 
-updateHomebrew().catch(error => {
+try {
+  await updateHomebrew()
+} catch (error) {
   console.error('error running scripts/release/homebrew.js', error)
+  // eslint-disable-next-line n/no-process-exit, unicorn/no-process-exit
   process.exit(1)
-})
+}

scripts/release/homebrew.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 import qq from 'qqjs'
-import getVersion from '../utils/_version.js'
+import getVersion from '../utils/version.js'
 
 qq.config.silent = false
 qq.run(async () => {

scripts/release/win

@@ -1,18 +1,16 @@
-import fs from 'fs'
-import { exec } from 'child_process'
+import {exec} from 'node:child_process'
+import fs from 'node:fs'
 
-fs.readdirSync('.')
+for (const c of fs.readdirSync('.')
   .filter(f => f.startsWith('heroku-v') && f.endsWith('.exe'))
   .flatMap(f =>
-    [process.env.STAMPY_UNSIGNED_BUCKET, process.env.STAMPY_SIGNED_BUCKET].map(b => `aws s3 rm ${b}/${f}`),
-  )
-  .forEach(c => {
-    exec(c, (error, stdout) => {
-      if (error) {
-        console.error(`exec error: ${error}`)
-        return
-      }
+    [process.env.STAMPY_UNSIGNED_BUCKET, process.env.STAMPY_SIGNED_BUCKET].map(b => `aws s3 rm ${b}/${f}`))) {
+  exec(c, (error, stdout) => {
+    if (error) {
+      console.error(`exec error: ${error}`)
+      return
+    }
 
-      console.log(stdout)
-    })
+    console.log(stdout)
   })
+}

scripts/stampy/empty-stampy-buckets.js

@@ -1,21 +1,19 @@
-import fs from 'fs'
-import { exec } from 'child_process'
+import {exec} from 'node:child_process'
+import fs from 'node:fs'
 
 fs.readdirSync('.')
   .filter(f => f.startsWith('heroku-v') && f.endsWith('.exe'))
   .map(f => ({
-    filename: f,
     cli: f.split('-')[0],
+    filename: f,
     // do it from the end to account for the possibility of the version having a hyphen in it like 2.2.2-beta.0
     sha: f.split('-').at(-2),
   }))
   .map(f => ({...f, shaIndex: f.filename.split('-').indexOf(f.sha)}))
   // version is the part between the cli and the sha
   .map(f => ({...f, version: f.filename.split('-').slice(1, f.shaIndex).join('-').replace('v', '')}))
-  .map(
-    f =>
-      `aws s3 cp ${f.filename} s3://heroku-cli-assets/versions/${f.version}/${f.sha}/${f.filename}`,
-  )
+  .map(f =>
+    `aws s3 cp ${f.filename} s3://heroku-cli-assets/versions/${f.version}/${f.sha}/${f.filename}`)
   .map(f => {
     exec(f, (error, stdout) => {
       if (error) {

scripts/stampy/upload-stampy-signed.js

@@ -1,13 +1,13 @@
-import path from 'path'
-import { fileURLToPath } from 'url'
-import fs from 'fs'
+import fs from 'node:fs'
+import path from 'node:path'
+import {fileURLToPath} from 'node:url'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
 const getHerokuS3Bucket = async () => {
   const packageJsonPath = path.join(__dirname, '..', '..', 'package.json')
-  const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'))
+  const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'))
   const bucket = packageJson.oclif?.update?.s3?.bucket
 
   if (!bucket) {

scripts/utils/_version.js

@@ -0,0 +1,19 @@
+import fs from 'node:fs'
+import path from 'node:path'
+import {fileURLToPath} from 'node:url'
+import qq from 'qqjs'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+
+export default async function getVersion() {
+  const packageJson = JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json'), 'utf8'))
+  let {version} = packageJson
+  if (version.includes('-')) {
+    const channel = version.split('-')[1].split('.')[0]
+    const sha = await qq.x.stdout('git', ['rev-parse', '--short', 'HEAD'])
+    version = `${version.split('-')[0]}-${channel}.${sha}`
+  }
+
+  return version
+}

scripts/utils/get-heroku-s3-bucket.js

@@ -1,7 +1,7 @@
 import {Hook} from '@oclif/core/hooks'
 
 const performance_analytics: Hook<'command_not_found'> = async function () {
-  const {isTelemetryEnabled, getTelemetryDisabledReason, telemetryDebug} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
+  const {getTelemetryDisabledReason, isTelemetryEnabled, telemetryDebug} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
 
   // Use the consolidated telemetry check
   if (!isTelemetryEnabled()) {
@@ -12,7 +12,7 @@ const performance_analytics: Hook<'command_not_found'> = async function () {
 
   telemetryDebug('Telemetry enabled: command_not_found hook setting up telemetry for invalid command')
   const {telemetryManager} = await import('../../lib/analytics-telemetry/telemetry-manager.js')
-  const globalAny = global as any
+  const globalAny = globalThis as any
   globalAny.cliTelemetry = telemetryManager.reportCmdNotFound(this.config)
 }