refactor: apply lint formatting to remaining commands (#3667)

* refactor: apply lint formatting to remaining commands

Applies automated lint formatting to remaining command files in preparation
for migration to eslint 9. Changes include import ordering, class property
ordering, object property ordering, and whitespace cleanup.

Affected command groups: pipelines, ps, rake, redis, regions, releases, repl,
reviewapps, run, sessions, spaces, status, teams, telemetry, usage, version,
webhooks.

* test: add minimal tests to increase coverage for spaces commands

Add error handling tests for missing required parameters:
- spaces:hosts without space name
- spaces:peerings:destroy without pcxid
- spaces:peerings without space name

These tests cover previously untested error handling paths.

* test: add comprehensive tests for config quote parse function

Adds 7 new test cases for the parse() function to increase code coverage from 35.48% to 100% for src/lib/config/quote.ts. New tests cover:
- Double-quoted strings with newlines and escaped characters
- Single-quoted strings with backslashes
- Empty strings and simple unquoted strings
- Error cases for multiple tokens and operator tokens

* chore: add --all flag to coverage commands

Ensures coverage reports include all source files, not just those that are tested. This provides a more accurate picture of overall code coverage.

* test: add unit tests for lib/run dyno and fix colorize tests

Adds comprehensive unit tests for the Dyno class:
- Constructor default values and option handling
- _useSSH protocol detection (http/https vs other protocols)
- _env environment variable building and TERM handling
- _isDebug HEROKU_DEBUG environment variable checking
- _status dyno status formatting with name and size
- _readData exit code parsing and output handling

Also updates colorize.unit.test.ts:
- Uncomments existing tests that were previously disabled
- Updates color code constants to match current 256-color ANSI codes
- All 7 colorize test cases now pass

These changes improve coverage for src/lib/run which previously had 38.68% coverage and dyno.ts which had no dedicated test file.

Author: eablack

package.json

@@ -386,8 +386,8 @@
     "lint": "eslint . --ext .ts --config .eslintrc.cjs",
     "lint:fix": "eslint . --ext .ts --config .eslintrc.cjs --fix --quiet",
     "lint:fix:all": "eslint . --ext .ts --config .eslintrc.cjs --fix",
-    "coverage": "c8 --reporter=lcov --reporter=text-summary npm run test",
-    "coverage:html": "c8 --reporter=html --reporter=text-summary npm run test",
+    "coverage": "c8 --all --reporter=lcov --reporter=text-summary npm run test",
+    "coverage:html": "c8 --all --reporter=html --reporter=text-summary npm run test",
     "create-shrinkwrap": "npm shrinkwrap",
     "prepublishOnly": "npm run create-shrinkwrap",
     "postpublish": "rm -f oclif.manifest.json",

src/commands/pipelines/add.ts

@@ -17,15 +17,12 @@ export default class PipelinesAdd extends Command {
       required: true,
     }),
   }
-
   static description = `add this app to a pipeline
 The app and pipeline names must be specified.
 The stage of the app will be guessed based on its name if not specified.`
-
   static examples = [
     color.command('heroku pipelines:add my-pipeline -a my-app -s production'),
   ]
-
   static flags = {
     app: flags.app({required: true}),
     remote: flags.remote(),

src/commands/pipelines/connect.ts

@@ -17,13 +17,10 @@ export default class Connect extends Command {
       required: true,
     }),
   }
-
   static description = 'connect a GitHub repo to an existing pipeline'
-
   static examples = [
     color.command('heroku pipelines:connect my-pipeline -r githuborg/reponame'),
   ]
-
   static flags = {
     repo: flags.string({
       char: 'r',

src/commands/pipelines/create.ts

@@ -23,18 +23,15 @@ export default class Create extends Command {
       required: false,
     }),
   }
-
   static description = `create a new pipeline
   An existing app must be specified as the first app in the pipeline.
   The pipeline name will be inferred from the app name if not specified.
   The stage of the app will be guessed based on its name if not specified.
   The pipeline owner will be the user creating the pipeline if not specified with -t for teams or -o for orgs.`
-
   static examples = [
     color.command('heroku pipelines:create -a my-app-staging'),
     color.command('heroku pipelines:create my-pipeline -a my-app-staging'),
   ]
-
   static flags = {
     app: flags.app({required: true}),
     remote: flags.remote(),

src/commands/pipelines/destroy.ts

@@ -13,9 +13,7 @@ export default class PipelinesDestroy extends Command {
       required: true,
     }),
   }
-
   static description = 'destroy a pipeline'
-
   static examples = [
     color.command('heroku pipelines:destroy my-pipeline'),
   ]

src/commands/pipelines/diff.ts

@@ -26,16 +26,13 @@ const PROMOTION_ORDER = ['development', 'staging', 'production']
 
 export default class PipelinesDiff extends Command {
   static description = 'compares the latest release of this app to its downstream app(s)'
-
   static examples = [
     color.command('heroku pipelines:diff -a my-app-staging'),
   ]
-
   static flags = {
     app: flags.app({required: true}),
     remote: flags.remote(),
   }
-
   getAppInfo = async (appName: string, appId: string, generation: GenerationKind): Promise<AppInfo> => {
     // Find GitHub connection for the app
     const githubApp = await this.kolkrabbi.getAppLink(appId)
@@ -70,7 +67,6 @@ export default class PipelinesDiff extends Command {
 
     return {hash: commit, name: appName, repo: githubApp.repo}
   }
-
   kolkrabbi: KolkrabbiAPI = new KolkrabbiAPI(this.config.userAgent, () => this.heroku.auth)
 
   async run() {
@@ -113,11 +109,12 @@ export default class PipelinesDiff extends Command {
 
     // Fetch GitHub repo/latest release hash for [target, downstream[0], .., downstream[n]] apps
     const appInfoPromises = [this.getAppInfo(targetAppName, targetAppId, generation)]
-    downstreamApps.forEach(app => {
+    for (const app of downstreamApps) {
       if (app.name && app.id) {
         appInfoPromises.push(this.getAppInfo(app.name, app.id, generation))
       }
-    })
+    }
+
     ux.action.start('Fetching release info for all apps')
     const appInfo = await Promise.all(appInfoPromises)
     ux.action.stop()
@@ -138,9 +135,7 @@ export default class PipelinesDiff extends Command {
     // Diff [{target, downstream[0]}, {target, downstream[1]}, .., {target, downstream[n]}]
     const downstreamAppsInfo = appInfo.slice(1)
     for (const downstreamAppInfo of downstreamAppsInfo) {
-      await diff(
-        targetAppInfo, downstreamAppInfo, githubAccount.github.token, this.config.userAgent,
-      )
+      await diff(targetAppInfo, downstreamAppInfo, githubAccount.github.token, this.config.userAgent)
     }
   }
 }

src/commands/pipelines/index.ts

@@ -5,11 +5,9 @@ import {ux} from '@oclif/core/ux'
 
 export default class Pipelines extends Command {
   static description = 'list pipelines you have access to'
-
   static examples = [
     color.command('heroku pipelines'),
   ]
-
   static flags = {
     json: flags.boolean({description: 'output in json format'}),
   }

src/commands/pipelines/info.ts

@@ -1,6 +1,6 @@
-import {color, hux} from '@heroku/heroku-cli-util'
 import {Command, flags} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
+import {color, hux} from '@heroku/heroku-cli-util'
 import {Args} from '@oclif/core'
 
 import {listPipelineApps} from '../../lib/api.js'
@@ -14,13 +14,10 @@ export default class PipelinesInfo extends Command {
       required: true,
     }),
   }
-
   static description = 'show list of apps in a pipeline'
-
   static examples = [
     color.command('heroku pipelines:info my-pipeline'),
   ]
-
   static flags = {
     json: flags.boolean({
       description: 'output in json format',

src/commands/pipelines/open.ts

@@ -10,9 +10,7 @@ export default class Open extends Command {
   static args = {
     pipeline: Args.string({description: 'name of pipeline', required: true}),
   }
-
   static description = 'open a pipeline in dashboard'
-
   static examples = [color.command('heroku pipelines:open my-pipeline')]
 
   async run() {

src/commands/pipelines/promote.ts

@@ -2,10 +2,10 @@ import {APIClient, Command, flags} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
 import {color, hux} from '@heroku/heroku-cli-util'
 import {ux} from '@oclif/core/ux'
-import assert from 'assert'
 import fetch from 'node-fetch'
-import * as Stream from 'stream'
-import * as util from 'util'
+import assert from 'node:assert'
+import * as Stream from 'node:stream'
+import {promisify} from 'node:util'
 
 import {AppWithPipelineCoupling, listPipelineApps} from '../../lib/api.js'
 import keyBy from '../../lib/pipelines/key-by.js'
@@ -27,11 +27,9 @@ const wait = (ms = 100) => new Promise(resolve => setTimeout(resolve, ms))
 
 export default class Promote extends Command {
   static description = 'promote the latest release of this app to its downstream app(s)'
-
   static examples = [
     color.command('heroku pipelines:promote -a my-app-staging'),
   ]
-
   static flags = {
     app: flags.app({
       required: true,
@@ -89,9 +87,7 @@ export default class Promote extends Command {
       promotionActionName = `Starting promotion to ${targetStage}`
     }
 
-    const promotion = await promote(
-      this.heroku, promotionActionName, coupling.pipeline!.id!, coupling.app!.id!, targetApps,
-    )
+    const promotion = await promote(this.heroku, promotionActionName, coupling.pipeline!.id!, coupling.app!.id!, targetApps)
 
     const pollLoop = pollPromotionStatus(this.heroku, promotion.id!, true)
     ux.stdout('Waiting for promotion to complete...')
@@ -228,7 +224,7 @@ async function streamReleaseCommand(heroku: APIClient, targets: Array<Heroku.App
   ux.stdout('Running release command...')
 
   async function streamReleaseOutput(releaseStreamUrl: string) {
-    const finished = util.promisify(Stream.finished)
+    const finished = promisify(Stream.finished)
     const fetchResponse = await fetch(releaseStreamUrl)
 
     if (fetchResponse.status >= 400) {