Skip to content

Commit c16b605

Browse files
committed
Addressing CX feedback
1 parent 200ccf2 commit c16b605

6 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/commands/data/pg/upgrade/run.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ export default class DataPgUpgradeRun extends BaseCommand {
1616
}),
1717
}
1818

19-
static description = 'upgrade the Postgres version on a Heroku Postgres Advanced database'
19+
static description = 'upgrade the Postgres version on a Postgres Advanced database'
2020

2121
static examples = [
2222
heredoc`
23-
# Upgrade a Heroku Postgres Advanced database to version 17
24-
<%= config.bin %> <%= command.id %> DATABASE --version 17 --app my-app
23+
# Upgrade a Postgres Advanced database to version 17
24+
${color.code('<%= config.bin %> <%= command.id %> DATABASE --version 17 --app my-app')}
2525
`,
2626
]
2727

@@ -43,7 +43,7 @@ export default class DataPgUpgradeRun extends BaseCommand {
4343
if (!utils.pg.isAdvancedDatabase(addon)) {
4444
ux.error(
4545
'You can only use this command on Advanced-tier databases.\n'
46-
+ `Run ${color.code(`heroku pg:upgrade:run ${addon.name} --app ${app}`)} instead.`,
46+
+ `Use ${color.code(`heroku pg:upgrade:run ${addon.name} --app ${app}`)} instead.`,
4747
)
4848
}
4949

@@ -65,7 +65,7 @@ export default class DataPgUpgradeRun extends BaseCommand {
6565
{body: {version}},
6666
)
6767
ux.action.stop()
68-
ux.stderr(`Upgrade started. Run ${color.code(`heroku data:pg:upgrade:wait ${addon.name} -a ${app}`)} to monitor progress.`)
68+
ux.stderr(`Upgrade started. Use ${color.code(`heroku data:pg:upgrade:wait ${addon.name} -a ${app}`)} to monitor progress.`)
6969
} catch (error: unknown) {
7070
ux.action.stop(color.red('!'))
7171
throw error

src/commands/data/pg/upgrade/wait.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ export default class DataPgUpgradeWait extends DataPgWait {
1111
static examples = [
1212
heredoc(`
1313
# Wait for upgrade to complete
14-
${color.command('heroku data:pg:upgrade:wait DATABASE --app myapp')}
14+
${color.code('<%= config.bin %> <%= command.id %> DATABASE --app myapp')}
1515
`),
1616
heredoc(`
1717
# Wait with custom polling interval (to avoid rate limiting)
18-
${color.command('heroku data:pg:upgrade:wait DATABASE --app myapp --wait-interval 10')}
18+
${color.code('<%= config.bin %> <%= command.id %> DATABASE --app myapp --wait-interval 10')}
1919
`),
2020
]
2121

src/commands/data/pg/wait.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default class DataPgWait extends BaseCommand {
2626
static examples = [
2727
heredoc(`
2828
# Wait for database to be available
29-
${color.command('heroku data:pg:wait DATABASE --app myapp')}
29+
${color.code('<%= config.bin %> <%= command.id %> DATABASE --app myapp')}
3030
`),
3131
]
3232

@@ -60,7 +60,7 @@ export default class DataPgWait extends BaseCommand {
6060
if (!isAdvancedDatabase(addon)) {
6161
ux.error(heredoc`
6262
You can only use this command on Advanced-tier databases.
63-
Run ${color.code(`heroku ${this.classicWaitCommand} ${addon.name} -a ${app}`)} instead.`)
63+
Use ${color.code(`heroku ${this.classicWaitCommand} ${addon.name} -a ${app}`)} instead.`)
6464
}
6565

6666
await this.waitFor(addon, waitInterval || 5, noNotify)

test/unit/commands/data/pg/upgrade/run.unit.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe('data:pg:upgrade:run', function () {
3838
expect(ansis.strip(stderr.output)).to.equal(
3939
heredoc(`
4040
Upgrading your ⛁ ${addon.name} database from 16.10 to the latest supported Postgres version... done
41-
Upgrade started. Run heroku data:pg:upgrade:wait advanced-horizontal-01234 -a myapp to monitor progress.
41+
Upgrade started. Use heroku data:pg:upgrade:wait advanced-horizontal-01234 -a myapp to monitor progress.
4242
`),
4343
)
4444
expect(stdout.output).to.equal('')
@@ -86,7 +86,7 @@ describe('data:pg:upgrade:run', function () {
8686
resolveApi.done()
8787
expect(ansis.strip((error as Error).message)).to.equal(
8888
'You can only use this command on Advanced-tier databases.\n'
89-
+ `Run heroku pg:upgrade:run ${addon.name} --app myapp instead.`,
89+
+ `Use heroku pg:upgrade:run ${addon.name} --app myapp instead.`,
9090
)
9191
}
9292
})

test/unit/commands/data/pg/upgrade/wait.unit.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ describe('data:pg:upgrade:wait', function () {
102102
const err = error as Error
103103
expect(ansis.strip(err.message)).to.equal(heredoc`
104104
You can only use this command on Advanced-tier databases.
105-
Run heroku pg:upgrade:wait standard-database -a myapp instead.`)
105+
Use heroku pg:upgrade:wait standard-database -a myapp instead.`)
106106
}
107107
})
108108

test/unit/commands/data/pg/wait.unit.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ describe('data:pg:wait', function () {
150150
const err = error as Error
151151
expect(ansis.strip(err.message)).to.equal(heredoc`
152152
You can only use this command on Advanced-tier databases.
153-
Run heroku pg:wait standard-database -a myapp instead.`)
153+
Use heroku pg:wait standard-database -a myapp instead.`)
154154
}
155155
})
156156

0 commit comments

Comments
 (0)