clean up addons info test

Author: eablack

packages/cli/test/unit/commands/addons/info.unit.test.ts

@@ -11,22 +11,28 @@ const {cache} = resolveAddon
 
 describe('addons:info', function () {
   let api: nock.Scope
+  let apiSdk: nock.Scope
 
   beforeEach(function () {
     api = nock('https://api.heroku.com')
+    apiSdk = nock('https://api.heroku.com', {
+      reqheaders: {
+        Accept: 'application/vnd.heroku+json; version=3.sdk',
+        'Accept-Expansion': 'addon_service,plan',
+      },
+    })
     cache.clear()
   })
 
   afterEach(function () {
     api.done()
+    apiSdk.done()
     nock.cleanAll()
   })
+
   context('with add-ons', function () {
     beforeEach(function () {
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'www-db', app: null})
         .reply(200, [fixtures.addons['www-db']])
       api.get(`/addons/${fixtures.addons['www-db'].id}/addon-attachments`).reply(200, [fixtures.attachments['acme-inc-www::DATABASE']])
@@ -51,10 +57,7 @@ State:        created\n
 
   context('with app add-ons', function () {
     beforeEach(function () {
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'www-db', app: 'example'})
         .reply(200, [fixtures.addons['www-db']])
       nock('https://api.heroku.com', {
@@ -90,10 +93,7 @@ State:        created\n
   })
   context('with app but not an app add-on', function () {
     beforeEach(function () {
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'www-db', app: 'example'})
         .reply(200, [fixtures.addons['www-db']])
       nock('https://api.heroku.com', {reqheaders: {'Accept-Expansion': 'addon_service,plan'}})
@@ -133,10 +133,7 @@ State:        created\n
     beforeEach(function () {
       const addon = fixtures.addons['dwh-db']
       addon.billed_price = {cents: 10000}
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'dwh-db', app: null})
         .reply(200, [addon])
       nock('https://api.heroku.com', {
@@ -172,10 +169,7 @@ State:        created\n
     beforeEach(function () {
       const addon = fixtures.addons['dwh-db']
       addon.billed_price = {cents: 0, contract: true}
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'dwh-db', app: null})
         .reply(200, [addon])
       nock('https://api.heroku.com', {
@@ -210,10 +204,7 @@ State:        created\n
   context('provisioning add-on', function () {
     beforeEach(function () {
       const provisioningAddon = fixtures.addons['www-redis']
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'www-redis', app: null})
         .reply(200, [provisioningAddon])
       nock('https://api.heroku.com', {reqheaders: {'Accept-Expansion': 'addon_service,plan'}})
@@ -244,10 +235,7 @@ State:        creating\n
   context('deprovisioning add-on', function () {
     beforeEach(function () {
       const deprovisioningAddon = fixtures.addons['www-redis-2']
-      nock('https://api.heroku.com', {reqheaders: {
-        Accept: 'application/vnd.heroku+json; version=3.sdk',
-        'Accept-Expansion': 'addon_service,plan',
-      }})
+      apiSdk
         .post('/actions/addons/resolve', {addon: 'www-redis-2', app: null})
         .reply(200, [deprovisioningAddon])
       nock('https://api.heroku.com', {reqheaders: {'Accept-Expansion': 'addon_service,plan'}})