Skip to content

Commit 7e489c1

Browse files
create CI matrix with heroku-24 and 22 (#14)
* create CI matrix with heroku-24 and 22 * kick ci * add done step * Update .github/workflows/build-and-test.yml Co-authored-by: Ed Morley <[email protected]> * Update .github/workflows/build-and-test.yml Co-authored-by: Ed Morley <[email protected]> --------- Co-authored-by: Ed Morley <[email protected]>
1 parent 1d97a92 commit 7e489c1

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/build-and-test.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ on: push
44

55
jobs:
66
test:
7+
strategy:
8+
matrix:
9+
stack: [heroku-20, heroku-22, heroku-24]
710
runs-on: ubuntu-latest
811

912
steps:
@@ -13,7 +16,7 @@ jobs:
1316
run: |
1417
./bin/compile . . .
1518
env:
16-
STACK: heroku-22
19+
STACK: ${{ matrix.stack }}
1720

1821
- name: Check Installation
1922
run: |

bin/install-chrome-dependencies

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ topic "Installing Chrome dependencies"
1515

1616
# Install correct dependencies according to $STACK
1717
case "${STACK}" in
18-
"heroku-18" | "heroku-20" | "heroku-22")
18+
"heroku-20" | "heroku-22" | "heroku-24")
1919
# the package list is found by using ci:debug then running ldd $GOOGLE_CHROME_BIN | grep not
2020
# also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
2121
PACKAGES="
@@ -47,7 +47,7 @@ case "${STACK}" in
4747
"
4848
;;
4949
*)
50-
error "STACK must be 'heroku-18', 'heroku-20' or 'heroku-22', not '${STACK}'."
50+
error "STACK must be 'heroku-20', 'heroku-22' or 'heroku-24', not '${STACK}'."
5151
esac
5252

5353
if [ ! -f $CACHE_DIR/PURGED_CACHE_V1 ]; then
@@ -58,7 +58,7 @@ if [ ! -f $CACHE_DIR/PURGED_CACHE_V1 ]; then
5858
touch $CACHE_DIR/PURGED_CACHE_V1
5959
fi
6060

61-
# This is where the original buildpack installed Chrome itself,
61+
# This is where the original buildpack installed Chrome itself,
6262
# but Chrome for Testing is installed from direct downloads.
6363
#
6464
# echo "Installing Google Chrome from the $channel channel." | indent

0 commit comments

Comments
 (0)