Skip to content

Commit 5d51e81

Browse files
committed
test: tighten node_10_spec EOL warning assertion to match full message
1 parent fe56ef9 commit 5d51e81

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

lib/binaries.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ install_nodejs() {
104104
fi
105105

106106
if [[ "$eol" == "true" ]]; then
107-
output::warn <<-EOF
107+
output::warning <<-EOF
108108
Node.js $version is now End-of-Life (EOL). It no longer receives security
109109
updates, bug fixes, or support from the Node.js project and is no longer
110110
supported on Heroku.

spec/ci/node_10_spec.rb

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,16 @@
88

99
it "should deploy successfully with EOL warning" do
1010
app.deploy do |app|
11-
expect(app.output).to include("End-of-Life")
11+
expect(clean_output(app.output)).to include(<<~OUTPUT)
12+
remote: ! Node.js 10.24.1 is now End-of-Life (EOL). It no longer receives security
13+
remote: ! updates, bug fixes, or support from the Node.js project and is no longer
14+
remote: ! supported on Heroku.
15+
remote: !
16+
remote: ! In a future buildpack release, this warning will become a build error. Please
17+
remote: ! upgrade to a supported version as soon as possible to avoid build failures.
18+
remote: !
19+
remote: ! https://devcenter.heroku.com/articles/nodejs-support#supported-node-js-versions
20+
OUTPUT
1221
expect(successful_body(app).strip).to eq("Hello, world!")
1322
expect(clean_output(app.output)).to include(<<~OUTPUT)
1423
remote: -----> Installing binaries

0 commit comments

Comments
 (0)