Skip to content

Commit a3f4f66

Browse files
authored
Fix tests not executing (#1517)
* Emit log order Issue #1505 spells out a problem where it appears ci-queue does not fail even when the test suite is broken. I'm unsure why this happens. To debug I'm emitting the tests that run so I can audit to make sure `rspec ./spec/helpers/yarn_installer_spec.rb:6` is executed. If it's not, then I need to diagnose why. If it is, then perhaps there some ordering bug that's affecting the outcome. * Update CI-queue * Update redis version * Use branch of ci-queue
1 parent adc4484 commit a3f4f66

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ group :development, :test do
1313
gem "parallel_tests"
1414
gem 'rspec-retry'
1515
gem 'json'
16-
gem 'ci-queue'
16+
gem 'ci-queue', github: "schneems/ci-queue", branch: "schneems/allow-hosted-redis"
1717
gem 'redis'
1818
gem 'dead_end'
1919
end

Gemfile.lock

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
1+
GIT
2+
remote: https://github.com/schneems/ci-queue.git
3+
revision: 285353ba8bc58e1b2ed02dedf55730400c27e32b
4+
branch: schneems/allow-hosted-redis
5+
specs:
6+
ci-queue (0.58.0)
7+
logger
8+
19
GEM
210
remote: https://rubygems.org/
311
specs:
412
base64 (0.2.0)
5-
ci-queue (0.55.0)
613
citrus (3.0.2)
714
connection_pool (2.4.1)
815
dead_end (4.0.0)
@@ -23,6 +30,7 @@ GEM
2330
thor (~> 1)
2431
threaded (~> 0)
2532
json (2.7.2)
33+
logger (1.6.1)
2634
moneta (1.0.0)
2735
multi_json (1.15.0)
2836
parallel (1.25.1)
@@ -34,7 +42,7 @@ GEM
3442
rate_throttle_client (~> 0.1.0)
3543
rake (13.2.1)
3644
rate_throttle_client (0.1.2)
37-
redis (5.2.0)
45+
redis (5.3.0)
3846
redis-client (>= 0.22.0)
3947
redis-client (0.22.2)
4048
connection_pool
@@ -57,7 +65,7 @@ PLATFORMS
5765
ruby
5866

5967
DEPENDENCIES
60-
ci-queue
68+
ci-queue!
6169
dead_end
6270
excon
6371
heroku_hatchet

app.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121
"scripts": {
2222
"test-setup": "bundle exec rake hatchet:setup_ci",
23-
"test": "bundle exec rspec-queue --max-requeues=3 --timeout 180 --queue $REDIS_URL || { cat log/test_order.log; $(exit 1); }"
23+
"test": "bundle exec rspec-queue --max-requeues=3 --timeout 180 --queue $REDIS_URL --format documentation || { cat log/test_order.log; $(exit 1); }"
2424
},
2525
"buildpacks": [
2626
{

0 commit comments

Comments
 (0)