Skip to content

Having rack gem is not a guarantee for having rackup executable (since Rack 3) #1356

@dentarg

Description

@dentarg

Spotted this when creating #1355

def default_process_types
# let's special case thin here if we detect it
web_process = bundler.has_gem?("thin") ?
"bundle exec thin start -R config.ru -e $RACK_ENV -p ${PORT:-5000}" :
"bundle exec rackup config.ru -p ${PORT:-5000}"
super.merge({
"web" => web_process
})
end

Since Rack 3, that code needs another guard on the rackup gem: https://github.com/rack/rack/blob/v3.0.3/UPGRADE-GUIDE.md#binrackup-was-moved-to-a-separate-gem

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions