latest schema.json invalid

[talbright]

$ script/generate
go: finding github.com/interagent/schematic/cmd/schematic latest
go: finding github.com/interagent/schematic/cmd latest
go: finding github.com/interagent/schematic latest
schematic: duplicate titles detected for identity-provider

[talbright]

Maybe not urgent yet, we haven't needed to update the client for the Heroku provider yet. However just making sure you folks are aware @alindeman @mars

[bernerdschaefer]

@talbright I missed this, I'll get someone to take a look at it or see if I can address it myself!

[talbright]

I'd almost say lets make sure the travis build runs the generate command so no PR can be merged until generate passes, but that would hold up non-generate related PRs.

[bernerdschaefer]

I'd almost say lets make sure the travis build runs the generate command so no PR can be merged until generate passes, but that would hold up non-generate related PRs.

@talbright This is definitely something we've talked about before, but hadn't captured as an work item. We now have open issues for both addressing the duplicate titles in the identity-provider schema and validating the schemas in CI. I'll share those with you out-of-band.

[talbright]

Doing this upstream sounds good 👍

[wchrisjohnson]

@bernerdschaefer if you'll share the second ticket with me, I'll see about adding a simple script to validate this each time CI runs. I just opened a PR with API for a related fix: https://github.com/heroku/api/pull/11689