Can't get PipelineID from ReviewAppConfig

[amatellanes]

After upgrading to latest version 5.4.0, I can't get PipelineID from ReviewAppConfig struct:

h := heroku.NewService(heroku.DefaultClient)
reviewAppConfig, err := h.ReviewAppConfigInfo(context.TODO(), "PIPELINE-ID")
if err != nil {
log.Fatal(err)
}
fmt.Println(reviewAppConfig.PipelineID)

This print an empty value.

I have made a call to Heroku API and it seems the pipeline ID is returned as an object but the field PipelineID in the ReviewAppConfig struct was modified here to be a string.

curl -nX GET https://api.heroku.com/pipelines/PIPELINE-ID/review-app-config \
-H "Accept: application/vnd.heroku+json; version=3" 

Response:

{
  ...
  "pipeline": {
    "id": "PIPELINE-ID"
  },
  ...
}

[mars]

I understand that you found a schema problem here @amatellanes, but if you already have the Pipeline ID to fetch the Review App Config, then why do you need to read the Pipeline ID out of the response?

[amatellanes]

Hi @mars,

Many thanks for replying my comment here too.

Sorry if I'm wrong now because I checked this some time ago... but I would say the problem is when you try to get review app config here, you rely on parsing the API response to the reviewAppConfig struct. Since the schema seems not to be valid, the pipeline ID in the review app config is empty and any successive API call would fail.