You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #42, I added new animation variants (rotate, sweep, dots, wave) to the existing Spinner component and tested them across sizes and colors. The default remains rotate.
During review, two main issues were raised:
Design System Alignment: The design system (Figma + documentation) has not defined these new spinner styles yet, so introducing them under Spinner may conflict with existing design conventions.
Component Architecture: There is interest in keeping Spinner minimal, and using a separate component (e.g. Loader) that is responsible for more expressive or contextual loading animations. This helps maintain separation of concerns.
💡 Proposal
Create a new component: Loader
Purpose
Encapsulate different styles of loading / loading animations
Serve as the home for expressive or contextual loading indicators
Allow Spinner to remain simple, supporting only the standard rotate style (or a minimal set aligned with the design system)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Background
In PR #42, I added new animation variants (
rotate,sweep,dots,wave) to the existingSpinnercomponent and tested them across sizes and colors. The default remainsrotate.During review, two main issues were raised:
Spinnermay conflict with existing design conventions.Spinnerminimal, and using a separate component (e.g.Loader) that is responsible for more expressive or contextual loading animations. This helps maintain separation of concerns.💡 Proposal
Create a new component:
LoaderPurpose
Spinnerto remain simple, supporting only the standard rotate style (or a minimal set aligned with the design system)🚀 Suggested API / Variants
Supported variants:
rotate(default)sweepdotswave📐 Design / Documentation
🔄 Migration / Backwards Compatibility
Spinnercan continue to support only therotatestyle.Loaderwithout breaking changes.Beta Was this translation helpful? Give feedback.
All reactions