Assert dynamic types in preparation for hhvm 25.11.0

hershel-theodore-layton · hershel-theodore-layton · commit fd159c174f66 · 2025-11-02T21:56:56.000+01:00
diff --git a/src/element/RootElement.hack b/src/element/RootElement.hack
@@ -60,8 +60,7 @@ abstract xhp class RootElement
     return $this->children;
   }
 
-  final public function getDataAndAriaAttributes(
-  )[]: dict<string, arraykey> {
+  final public function getDataAndAriaAttributes()[]: dict<string, arraykey> {
     return $this->dataAndAria;
   }
 
@@ -275,7 +274,7 @@ abstract xhp class RootElement
   }
 
   private static function typeName(mixed $mixed)[]: string {
-    return \is_object($mixed) ? \get_class($mixed) : \gettype($mixed);
+    return \is_object($mixed) ? \get_class($mixed) : \gettype($mixed) as string;
   }
 
   private static function flattenChildren(

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,7 @@ abstract xhp class RootElement`
`60`	`60`	`return $this->children;`
`61`	`61`	`}`
`62`	`62`
`63`		`- final public function getDataAndAriaAttributes(`
`64`		`- )[]: dict<string, arraykey> {`
	`63`	`+ final public function getDataAndAriaAttributes()[]: dict<string, arraykey> {`
`65`	`64`	`return $this->dataAndAria;`
`66`	`65`	`}`
`67`	`66`
`@@ -275,7 +274,7 @@ abstract xhp class RootElement`
`275`	`274`	`}`
`276`	`275`
`277`	`276`	`private static function typeName(mixed $mixed)[]: string {`
`278`		`- return \is_object($mixed) ? \get_class($mixed) : \gettype($mixed);`
	`277`	`+ return \is_object($mixed) ? \get_class($mixed) : \gettype($mixed) as string;`
`279`	`278`	`}`
`280`	`279`
`281`	`280`	`private static function flattenChildren(`