Skip to content

Commit 66c47fd

Browse files
authored
Merge pull request #72 from hetalang/emptysim
fix for empty vectors in simulations
2 parents 20218c8 + 71ff78b commit 66c47fd

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

src/solution_interface.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
############################ Accessing Solution Values #####################
22

33
observables(sr::SimResult) = observables(sr.sim)
4-
observables(sim::Simulation) = collect(keys(sim.vals.u[1]))
4+
observables(sim::Simulation) = collect(LabelledArrays.symnames(eltype(sim.vals.u)))
55
observables(sim::MCResult) = observables(sim[1])
66
#parameters(sim::SimResult) = sim.scenario.prob.p
77

src/types.jl

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,23 @@ end
231231

232232
# copy fix is tmp needed not to rewrite SavedValues with new simulation
233233
Simulation(sv::SavedValues, params, status) = Simulation(
234-
DiffEqArray(copy(sv.u),copy(sv.t)),
234+
SciMLBase.RecursiveArrayTools.DiffEqArray(sv),
235235
copy(sv.scope),
236236
params,
237237
Symbol(status)
238238
)
239239

240+
function SciMLBase.RecursiveArrayTools.DiffEqArray(sv::SavedValues, p=nothing; safetycopy=true)
241+
vec = sv.u
242+
ts = sv.t
243+
vars = !isempty(vec) ? collect(symbols(vec[1])) : []
244+
if safetycopy
245+
return SciMLBase.RecursiveArrayTools.DiffEqArray(copy(vec), copy(ts), p; variables = vars)
246+
else
247+
return SciMLBase.RecursiveArrayTools.DiffEqArray(vec, ts, p; variables = vars)
248+
end
249+
end
250+
240251
status(s::Simulation) = s.status
241252
times(s::Simulation) = s.vals.t
242253
vals(s::Simulation) = s.vals.u

0 commit comments

Comments
 (0)