Fix inverted feature names

[andsens]

I would like to suggest renaming some loadbalancer annotations and their defaults in the upcoming v2.0.

The following annotations have negated names:

load-balancer.hetzner.cloud/ipv6-disabled (false)
load-balancer.hetzner.cloud/disable-public-network (false)
load-balancer.hetzner.cloud/disable-private-ingress (false)

Generally it is confusing to read code with negations, e.g. dontDoTheThing=false. It requires unnecessary brainpower to calculate whether that means that the thing is being done or not. So my suggestion would be to negate the names and the defaults:

load-balancer.hetzner.cloud/enable-ipv6 (true)
load-balancer.hetzner.cloud/use-public-network (true)
load-balancer.hetzner.cloud/allow-private-ingress (true)

I haven't checked whether there are other places where this would make sense.

[andsens]

Also, there is no real naming convention for boolean flags
Sometimes its <imperative-verb>-<thing> like use-private-ip, other times its uses-proxyprotocol, but there's also http-sticky-sessions

[lukasmetzner]

Hey,

thank you for creating the issue. We already planned to revise configuration options, their naming, their defaults and also would like to introduce a proper config file as an alternative to a large set of environment variables. #656 is also related to this.

I will add this issue to the v2.0 milestone.

Best Regards,
Lukas

[github-actions]

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.