Skip to content

Commit 938d993

Browse files
authored
Fix codecov commands (#23)
* fix commands * update readme Signed-off-by: Nikolay Gagarinov <[email protected]> * update readme * update PHP version * update codeclimate aciton * trigger ci * try fix codecov * comment test-coverage --------- Signed-off-by: Nikolay Gagarinov <[email protected]>
1 parent aee8286 commit 938d993

File tree

3 files changed

+34
-23
lines changed

3 files changed

+34
-23
lines changed

.github/workflows/workflow.yml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,22 @@ jobs:
2323
uses: shivammathur/setup-php@v2
2424
with:
2525
# Specify the PHP version
26-
php-version: '8.1'
26+
php-version: '8.2'
2727
- name: Install
2828
# Install project
2929
run: make install
3030
- name: Run linter
3131
# Run Linter
3232
run: make lint
33-
# Publish code coverage on Code Climate
34-
# https://github.com/paambaati/codeclimate-action
35-
- name: Run test & publish code coverage
36-
uses: paambaati/[email protected]
37-
# Add Code Climate secret key
38-
env:
39-
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
40-
with:
41-
coverageCommand: make test-coverage
42-
coverageLocations: ${{github.workplace}}/build/logs/clover.xml:clover
43-
debug: true
33+
# Publish code coverage on Code Climate
34+
# https://github.com/paambaati/codeclimate-action
35+
# NOTE: uncomment for using workflow
36+
# - name: Run test & publish code coverage
37+
# uses: paambaati/codeclimate-action@v5
38+
# # Add Code Climate secret key
39+
# env:
40+
# CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
41+
# with:
42+
# coverageCommand: make test-coverage
43+
# coverageLocations: build/logs/clover.xml:clover
44+
# debug: true

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,7 @@ test:
1515
composer exec --verbose phpunit tests
1616

1717
test-coverage:
18-
composer exec --verbose phpunit tests -- --coverage-clover build/logs/clover.xml
18+
XDEBUG_MODE=coverage composer exec --verbose phpunit tests -- --coverage-clover build/logs/clover.xml
19+
20+
test-coverage-text:
21+
XDEBUG_MODE=coverage composer exec --verbose phpunit tests -- --coverage-text

README.md

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,41 @@
55
[![Issue Count](https://codeclimate.com/github/hexlet-boilerplates/php-package/badges/issue_count.svg)](https://codeclimate.com/github/hexlet-boilerplates/php-package/issues)
66
[![Test Coverage](https://codeclimate.com/github/hexlet-boilerplates/php-package/badges/coverage.svg)](https://codeclimate.com/github/hexlet-boilerplates/php-package/coverage)
77

8+
## Prerequisites
9+
10+
* Linux, Macos, WSL
11+
* PHP >=8.2
12+
* Xdebug
13+
* Make
14+
* Git
15+
816
## Addons
917

1018
Use <http://psysh.org/>
1119

1220
## Setup
1321

14-
```sh
15-
$ git clone https://github.com/hexlet-boilerplates/php-package.git
16-
17-
$ cd php-package
18-
19-
$ make install
22+
```bash
23+
git clone https://github.com/hexlet-boilerplates/php-package.gi
24+
cd php-package
25+
make install
2026
```
2127

2228
## Run tests
2329

2430
```sh
25-
$ make test
31+
make test
2632
```
2733

2834
## Test Coverage
2935

30-
- see `phpunit.xml`
31-
- <https://docs.codeclimate.com/docs/configuring-test-coverage>
32-
- add CC_TEST_REPORTER_ID to workflow as SECERETS ENV VARIABLE (for safety)
36+
* see `phpunit.xml`
37+
* See [codeclimate documentation](https://docs.codeclimate.com/docs/configuring-test-coverage)
38+
* add `CC_TEST_REPORTER_ID` to workflow as SECRETS ENV VARIABLE (for safety)
3339

3440
[![Hexlet Ltd. logo](https://raw.githubusercontent.com/Hexlet/assets/master/images/hexlet_logo128.png)](https://hexlet.io/?utm_source=github&utm_medium=link&utm_campaign=php-package)
3541

3642
This repository is created and maintained by the team and the community of Hexlet, an educational project. [Read more about Hexlet](https://hexlet.io/?utm_source=github&utm_medium=link&utm_campaign=php-package).
3743

44+
3845
See most active contributors on [hexlet-friends](https://friends.hexlet.io/).

0 commit comments

Comments
 (0)