Skip to content

Commit 900ef32

Browse files
committed
Fix logger credo
1 parent 883bb35 commit 900ef32

File tree

1 file changed

+10
-8
lines changed
  • services/app/apps/codebattle/lib/codebattle/tournament/storage

1 file changed

+10
-8
lines changed

services/app/apps/codebattle/lib/codebattle/tournament/storage/ranking.ex

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
defmodule Codebattle.Tournament.Storage.Ranking do
22
@moduledoc false
3+
require Logger
4+
35
def create_table(id) do
46
:ets.new(
57
:"t_#{id}_ranking",
@@ -20,7 +22,7 @@ defmodule Codebattle.Tournament.Storage.Ranking do
2022
:ets.insert(tournament.ranking_table, records)
2123
rescue
2224
_e ->
23-
IO.inspect(records, label: "Error inserting ranking records")
25+
Logger.error("Error inserting ranking records: #{inspect(records)}")
2426
[]
2527
end
2628
end)
@@ -30,7 +32,7 @@ defmodule Codebattle.Tournament.Storage.Ranking do
3032
:ets.insert(tournament.ranking_table, {place, record.id, record})
3133
rescue
3234
_e ->
33-
IO.inspect({place, record.id, record}, label: "Error inserting single ranking record")
35+
Logger.error("Error inserting single ranking record: #{inspect({place, record.id, record})}")
3436
end
3537

3638
def drop_player(tournament, player_id) do
@@ -40,7 +42,7 @@ defmodule Codebattle.Tournament.Storage.Ranking do
4042
:ets.select_delete(tournament.ranking_table, match_spec)
4143
rescue
4244
_e ->
43-
IO.inspect({player_id, tournament}, label: "Error dropping player from ranking")
45+
Logger.error("Error dropping player from ranking: #{inspect({player_id, tournament})}")
4446
end
4547
end
4648

@@ -50,15 +52,15 @@ defmodule Codebattle.Tournament.Storage.Ranking do
5052
])
5153
rescue
5254
_e ->
53-
IO.inspect({tournament, limit}, label: "Error getting first ranking records")
55+
Logger.error("Error getting first ranking records: #{inspect({tournament, limit})}")
5456
[]
5557
end
5658

5759
def get_all(tournament) do
5860
:ets.select(tournament.ranking_table, [{{:_, :_, :"$3"}, [], [:"$3"]}])
5961
rescue
6062
_e ->
61-
IO.inspect(tournament, label: "Error getting all ranking records")
63+
Logger.error("Error getting all ranking records: #{inspect(tournament)}")
6264
[]
6365
end
6466

@@ -69,15 +71,15 @@ defmodule Codebattle.Tournament.Storage.Ranking do
6971
end
7072
rescue
7173
_e ->
72-
IO.inspect({tournament, id}, label: "Error getting ranking record by id")
74+
Logger.error("Error getting ranking record by id: #{inspect({tournament, id})}")
7375
nil
7476
end
7577

7678
def count(tournament) do
7779
:ets.select_count(tournament.ranking_table, [{:_, [], [true]}])
7880
rescue
7981
_e ->
80-
IO.inspect(tournament, label: "Error counting ranking records")
82+
Logger.error("Error counting ranking records: #{inspect(tournament)}")
8183
0
8284
end
8385

@@ -87,7 +89,7 @@ defmodule Codebattle.Tournament.Storage.Ranking do
8789
])
8890
rescue
8991
_e ->
90-
IO.inspect({tournament, start_place, end_place}, label: "Error getting slice of ranking records")
92+
Logger.error("Error getting slice of ranking records: #{inspect({tournament, start_place, end_place})}")
9193
[]
9294
end
9395
end

0 commit comments

Comments
 (0)