Minor improvements

Author: vtm9

k8s/app-chart/values.yaml

@@ -22,13 +22,6 @@ codebattle:
     type: ClusterIP
     port: 4000
   env:
-    CODEBATTLE_SHOW_EXTENSION_POPUP: "true"
-    CODEBATTLE_USE_EXTERNAL_JS: "true"
-    CODEBATTLE_CREATE_BOT_GAMES: "true"
-    CODEBATTLE_IMPORT_GITHUB_TASKS: "true"
-    CODEBATTLE_ALLOW_GUESTS: "true"
-    CODEBATTLE_USE_PRESENCE: "true"
-    CODEBATTLE_RECORD_GAMES: "true"
     CODEBATTLE_VERSION: "{{ .Values.version }}"
     CODEBATTLE_PORT: 4000
 
@@ -66,7 +59,6 @@ runnerRust:
       image: codebattle/python:3.12.2
       replicaCount: 3
 
-
 resources: {}
 nodeSelector: {}
 tolerations: []

k8s/timoni/codebattle/values.cue

@@ -19,12 +19,5 @@ values: {
 		}
 	}
 	env: {
-		"CODEBATTLE_SHOW_EXTENSION_POPUP": true
-		"CODEBATTLE_USE_EXTERNAL_JS":      true
-		"CODEBATTLE_CREATE_BOT_GAMES":     true
-		"CODEBATTLE_IMPORT_GITHUB_TASKS":  true
-		"CODEBATTLE_ALLOW_GUESTS":         true
-		"CODEBATTLE_USE_PRESENCE":         true
-		"CODEBATTLE_RECORD_GAMES":         true
 	}
 }

services/app/apps/codebattle/lib/codebattle/application.ex

@@ -15,30 +15,12 @@ defmodule Codebattle.Application do
       config_path |> Config.Reader.read!() |> Application.put_all_env()
     end
 
-    github_tasks =
-      if Application.get_env(:codebattle, :import_github_tasks) do
-        [{Codebattle.TasksImporter, []}]
-      else
-        []
-      end
-
-    bot_games =
-      if Application.get_env(:codebattle, :create_bot_games) do
-        [{Codebattle.Bot.GameCreator, []}]
-      else
-        []
-      end
-
-    user_rank =
-      if Application.get_env(:codebattle, :user_rank_server) do
-        [{Codebattle.UsersRankUpdateServer, []}]
-      else
-        []
-      end
-
     children =
       [
         {ChromicPDF, chromic_pdf_opts()},
+        {Codebattle.TasksImporter, []},
+        {Codebattle.UsersRankUpdateServer, []},
+        {Codebattle.Bot.GameCreator, []},
         {Codebattle.ImageCache, []},
         {Codebattle.Repo, []},
         {Registry, keys: :unique, name: Codebattle.Registry},
@@ -65,7 +47,7 @@ defmodule Codebattle.Application do
           id: Codebattle.Chat.Lobby,
           start: {Codebattle.Chat, :start_link, [:lobby, %{message_ttl: to_timeout(hour: 8)}]}
         }
-      ] ++ github_tasks ++ bot_games ++ user_rank
+      ]
 
     Supervisor.start_link(children,
       strategy: :one_for_one,

services/app/apps/codebattle/lib/codebattle/bot/game_creator.ex

@@ -5,7 +5,7 @@ defmodule Codebattle.Bot.GameCreator do
   alias Codebattle.Bot
   alias Codebattle.Game
 
-  @timeout to_timeout(second: 3)
+  @timeout Application.compile_env(:codebattle, :start_create_bot_timeout)
 
   @spec start_link([]) :: GenServer.on_start()
   def start_link(_) do
@@ -15,16 +15,22 @@ defmodule Codebattle.Bot.GameCreator do
   @impl GenServer
   def init(_state) do
     Process.send_after(self(), :create_bot_if_needed, @timeout)
+
     {:ok, :noop}
   end
 
   @impl GenServer
   def handle_info(:create_bot_if_needed, state) do
-    for level <- Codebattle.Task.levels() do
-      create_game(level)
+    if FunWithFlags.enabled?(:skip_bot_games) do
+      :noop
+    else
+      for level <- Codebattle.Task.levels() do
+        create_game(level)
+      end
+
+      Process.send_after(self(), :create_bot_if_needed, @timeout)
     end
 
-    Process.send_after(self(), :create_bot_if_needed, @timeout)
     {:noreply, state}
   end
 

services/app/apps/codebattle/lib/codebattle/game/server.ex

@@ -48,7 +48,7 @@ defmodule Codebattle.Game.Server do
 
     state = %{
       game: game,
-      is_record_games: Application.get_env(:codebattle, :record_games),
+      is_record_games: !FunWithFlags.enabled?(:skip_record_games),
       playbook_state: %{records: [], id: 0}
     }
 

services/app/apps/codebattle/lib/codebattle/tasks_importer.ex

@@ -25,13 +25,20 @@ defmodule Codebattle.TasksImporter do
   # SERVER
   def init(state) do
     Logger.debug("Start Tasks Importer")
+
     Process.send_after(self(), :run, to_timeout(second: 17))
+
     {:ok, state}
   end
 
   def handle_info(:run, state) do
-    upsert(fetch_issues())
-    Process.send_after(self(), :run, @timeout)
+    if FunWithFlags.enabled?(:use_import_github_tasks) do
+      upsert(fetch_issues())
+      Process.send_after(self(), :run, @timeout)
+    else
+      :noop
+    end
+
     {:noreply, state}
   end
 

services/app/apps/codebattle/lib/codebattle/users_rank_update_server.ex

@@ -19,9 +19,10 @@ defmodule Codebattle.UsersRankUpdateServer do
   # SERVER
   def init(_) do
     Process.send_after(self(), :work, @timeout)
+    Process.send_after(self(), :subscribe, @timeout)
 
-    Codebattle.PubSub.subscribe("games")
     Logger.debug("Start UsersRankServer")
+
     {:ok, true}
   end
 
@@ -30,12 +31,26 @@ defmodule Codebattle.UsersRankUpdateServer do
     {:noreply, state}
   end
 
-  def handle_info(:work, state) do
-    do_work()
-    Process.send_after(self(), :work, @timeout)
+  def handle_info(:subscribe, state) do
+    if FunWithFlags.enabled?(:skip_user_rank_server) do
+      :noop
+    else
+      Codebattle.PubSub.subscribe("games")
+    end
+
     {:noreply, state}
   end
 
+  def handle_info(:work, state) do
+    if FunWithFlags.enabled?(:skip_user_rank_server) do
+      :noop
+    else
+      do_work()
+      Process.send_after(self(), :work, @timeout)
+      {:noreply, state}
+    end
+  end
+
   def handle_info(%{event: "game:finished", payload: %{tournament_id: nil}}, state) do
     do_work()
     {:noreply, state}

services/app/apps/codebattle/lib/codebattle_web/channels/main_channel.ex

@@ -15,7 +15,7 @@ defmodule CodebattleWeb.MainChannel do
         topic = "main:#{current_user.id}"
         Codebattle.PubSub.subscribe(topic)
 
-        if Application.get_env(:codebattle, :use_presence) do
+        if !FunWithFlags.enabled?(:skip_presence) do
           send(self(), {:after_join, state})
         end
 

services/app/apps/codebattle/lib/codebattle_web/controllers/root_controller.ex

@@ -41,6 +41,10 @@ defmodule CodebattleWeb.RootController do
     end
   end
 
+  def maintenance(conn, _) do
+    render(conn, "maintenance.html", layout: {LayoutView, "empty.html"})
+  end
+
   def feedback(conn, _) do
     render(conn, "feedback.xml")
   end

services/app/apps/codebattle/lib/codebattle_web/controllers/session_controller.ex

@@ -5,7 +5,7 @@ defmodule CodebattleWeb.SessionController do
 
   def new(conn, _params) do
     cond do
-      Application.get_env(:codebattle, :use_only_token_auth) ->
+      FunWithFlags.enabled?(:use_only_token_auth) ->
         render(conn, "token_only.html")
 
       Application.get_env(:codebattle, :use_local_password_auth) ->