Skip to content

Commit f7eda55

Browse files
committed
FIxes
1 parent dda984c commit f7eda55

File tree

4 files changed

+23
-10
lines changed

4 files changed

+23
-10
lines changed

services/app/apps/codebattle/assets/js/widgets/pages/game/TournamentRankingTable.jsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const tableDataCellClassName = cn(
2828

2929
const TournamentRankingTable = () => {
3030
const currentUserClanId = useSelector(currentUserClanIdSelector);
31-
const { ranking } = useSelector(tournamentSelector);
31+
const { ranking, currentRoundPosition, roundTaskIds } = useSelector(tournamentSelector);
3232

3333
return (
3434
<div
@@ -109,6 +109,13 @@ const TournamentRankingTable = () => {
109109
</tbody>
110110
</table>
111111
</div>
112+
{roundTaskIds?.length > 0 && (
113+
<div className="d-flex justify-content-center align-items-center mt-2 mb-2">
114+
<span className="font-weight-bold">
115+
{i18next.t('Task')}: {currentRoundPosition + 1} / {roundTaskIds.length}
116+
</span>
117+
</div>
118+
)}
112119
</div>
113120
);
114121
};

services/app/apps/codebattle/lib/codebattle/game/engine.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ defmodule Codebattle.Game.Engine do
388388
end
389389

390390
def toggle_ban_player(%Game{} = game, player_id) do
391-
{:ok, {_old_game_state, new_game}} = fire_transition(game.id, :toggle_ban_player, %{player_id: player_id})
391+
{:ok, {_old_game_state, new_game}} = fire_transition(game.id, :toggle_ban_player, %{id: player_id})
392392
{:ok, new_game}
393393
end
394394

services/app/apps/codebattle/lib/codebattle/game/fsm.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ defmodule Codebattle.Game.Fsm do
111111
{:ok, Map.put(game, :locked, false)}
112112
end
113113

114-
def transition(:toggle_ban_player, game, %{player_id: player_id}) do
114+
def transition(:toggle_ban_player, game, %{id: player_id}) do
115115
new_players =
116116
Enum.map(game.players, fn player ->
117117
if player.id == player_id do

services/app/apps/codebattle/lib/codebattle_web/channels/game_channel.ex

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ defmodule CodebattleWeb.GameChannel do
3535

3636
ranking =
3737
tournament
38-
|> Tournament.Ranking.get_first(6)
38+
|> Tournament.Ranking.get_first(5)
3939
|> Enum.concat([Tournament.Ranking.get_by_player(tournament, current_player)])
4040
|> Enum.filter(& &1)
4141
|> Enum.uniq_by(& &1.id)
@@ -324,9 +324,12 @@ defmodule CodebattleWeb.GameChannel do
324324
def handle_info(%{event: "user:banned", payload: %{player: player}}, socket) do
325325
user_id = socket.assigns.current_user.id
326326

327-
if user_id == player.id do
328-
socket = assign(socket, banned?: true)
329-
end
327+
socket =
328+
if user_id == player.id do
329+
assign(socket, banned?: true)
330+
else
331+
socket
332+
end
330333

331334
push(socket, "user:banned", %{user_id: player.id})
332335
{:noreply, socket}
@@ -335,9 +338,12 @@ defmodule CodebattleWeb.GameChannel do
335338
def handle_info(%{event: "user:unbanned", payload: %{player: player}}, socket) do
336339
user_id = socket.assigns.current_user.id
337340

338-
if user_id == player.id do
339-
socket = assign(socket, banned?: false)
340-
end
341+
socket =
342+
if user_id == player.id do
343+
assign(socket, banned?: false)
344+
else
345+
socket
346+
end
341347

342348
push(socket, "user:unbanned", %{user_id: player.id})
343349
{:noreply, socket}

0 commit comments

Comments
 (0)