Skip to content

Commit 2a32225

Browse files
author
Alina Tarasova
committed
Deleted @transactional and added @AfterEach in tests
1 parent 856ee81 commit 2a32225

File tree

3 files changed

+44
-17
lines changed

3 files changed

+44
-17
lines changed

src/test/java/io/hexlet/blog/controller/api/PostsCommentsControllerTest.java

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
import com.fasterxml.jackson.databind.ObjectMapper;
1111
import io.hexlet.blog.dto.PostCommentDTO;
1212
import io.hexlet.blog.mapper.PostCommentMapper;
13+
import io.hexlet.blog.model.User;
1314
import org.assertj.core.api.Assertions;
1415
import org.instancio.Instancio;
1516
import org.junit.jupiter.api.BeforeEach;
17+
import org.junit.jupiter.api.AfterEach;
1618
import org.junit.jupiter.api.Test;
1719
import org.springframework.beans.factory.annotation.Autowired;
1820
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
@@ -24,18 +26,16 @@
2426
import io.hexlet.blog.repository.PostCommentRepository;
2527
import io.hexlet.blog.repository.PostRepository;
2628
import io.hexlet.blog.util.ModelGenerator;
27-
import io.hexlet.blog.util.UserUtils;
28-
import jakarta.transaction.Transactional;
2929
import org.springframework.test.web.servlet.setup.MockMvcBuilders;
3030
import org.springframework.web.context.WebApplicationContext;
31+
import io.hexlet.blog.repository.UserRepository;
3132

3233
import java.nio.charset.StandardCharsets;
3334
import java.util.List;
3435
import java.util.Map;
3536

3637

3738
@SpringBootTest
38-
@Transactional
3939
@AutoConfigureMockMvc
4040
public class PostsCommentsControllerTest {
4141

@@ -55,7 +55,7 @@ public class PostsCommentsControllerTest {
5555
private PostCommentRepository postCommentRepository;
5656

5757
@Autowired
58-
private UserUtils userUtils;
58+
private UserRepository userRepository;
5959

6060
private JwtRequestPostProcessor token;
6161

@@ -67,6 +67,8 @@ public class PostsCommentsControllerTest {
6767
@Autowired
6868
private PostCommentMapper postCommentMapper;
6969

70+
private User testUser;
71+
7072

7173
@BeforeEach
7274
public void setUp() {
@@ -75,29 +77,38 @@ public void setUp() {
7577
.apply(springSecurity())
7678
.build();
7779

78-
token = jwt().jwt(builder -> builder.subject("[email protected]"));
80+
testUser = Instancio.of(modelGenerator.getUserModel()).create();
81+
userRepository.save(testUser);
82+
token = jwt().jwt(builder -> builder.subject(testUser.getEmail()));
7983

8084
testPost = Instancio.of(modelGenerator.getPostModel())
8185
.create();
82-
testPost.setAuthor(userUtils.getTestUser());
86+
testPost.setAuthor(testUser);
8387
postRepository.save(testPost);
8488

8589
var testPost2 = Instancio.of(modelGenerator.getPostModel())
8690
.create();
87-
testPost2.setAuthor(userUtils.getTestUser());
91+
testPost2.setAuthor(testUser);
8892
postRepository.save(testPost2);
8993

9094
var testPostComment = Instancio.of(modelGenerator.getPostCommentModel()).create();
9195
testPostComment.setPost(testPost);
92-
testPostComment.setAuthor(userUtils.getTestUser());
96+
testPostComment.setAuthor(testUser);
9397
postCommentRepository.save(testPostComment);
9498

9599
var testPostComment2 = Instancio.of(modelGenerator.getPostCommentModel()).create();
96100
testPostComment2.setPost(testPost2);
97-
testPostComment2.setAuthor(userUtils.getTestUser());
101+
testPostComment2.setAuthor(testUser);
98102
postCommentRepository.save(testPostComment2);
99103
}
100104

105+
@AfterEach
106+
public void clean() {
107+
postCommentRepository.deleteAll();
108+
postRepository.deleteAll();
109+
userRepository.deleteAll();
110+
}
111+
101112
@Test
102113
public void testIndex() throws Exception {
103114
var result = mockMvc.perform(get("/api/posts_comments").with(token))

src/test/java/io/hexlet/blog/controller/api/PostsControllerTest.java

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,11 @@
1313

1414
import com.fasterxml.jackson.core.type.TypeReference;
1515
import io.hexlet.blog.dto.PostDTO;
16+
import io.hexlet.blog.model.User;
17+
import io.hexlet.blog.repository.UserRepository;
1618
import org.assertj.core.api.Assertions;
1719
import org.instancio.Instancio;
20+
import org.junit.jupiter.api.AfterEach;
1821
import org.junit.jupiter.api.BeforeEach;
1922
import org.junit.jupiter.api.Test;
2023
import org.openapitools.jackson.nullable.JsonNullable;
@@ -32,7 +35,6 @@
3235
import io.hexlet.blog.model.Post;
3336
import io.hexlet.blog.repository.PostRepository;
3437
import io.hexlet.blog.util.ModelGenerator;
35-
import io.hexlet.blog.util.UserUtils;
3638
import org.springframework.test.web.servlet.setup.MockMvcBuilders;
3739
import org.springframework.web.context.WebApplicationContext;
3840

@@ -63,12 +65,14 @@ public class PostsControllerTest {
6365
private PostRepository postRepository;
6466

6567
@Autowired
66-
private UserUtils userUtils;
68+
private UserRepository userRepository;
6769

6870
private JwtRequestPostProcessor token;
6971

7072
private Post testPost;
7173

74+
private User testUser;
75+
7276

7377
@BeforeEach
7478
public void setUp() {
@@ -77,11 +81,19 @@ public void setUp() {
7781
.apply(springSecurity())
7882
.build();
7983

80-
token = jwt().jwt(builder -> builder.subject("[email protected]"));
84+
testUser = Instancio.of(modelGenerator.getUserModel()).create();
85+
userRepository.save(testUser);
86+
token = jwt().jwt(builder -> builder.subject(testUser.getEmail()));
8187

8288
testPost = Instancio.of(modelGenerator.getPostModel())
8389
.create();
84-
testPost.setAuthor(userUtils.getTestUser());
90+
testPost.setAuthor(testUser);
91+
}
92+
93+
@AfterEach
94+
public void clean() {
95+
postRepository.deleteAll();
96+
userRepository.deleteAll();
8597
}
8698

8799
@Test

src/test/java/io/hexlet/blog/controller/api/UsersControllerTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import io.hexlet.blog.mapper.UserMapper;
2020
import org.assertj.core.api.Assertions;
2121
import org.instancio.Instancio;
22+
import org.junit.jupiter.api.AfterEach;
2223
import org.junit.jupiter.api.BeforeEach;
2324
import org.junit.jupiter.api.Test;
2425
import org.springframework.beans.factory.annotation.Autowired;
@@ -75,11 +76,14 @@ public void setUp() {
7576
.apply(springSecurity())
7677
.build();
7778

78-
token = jwt().jwt(builder -> builder.subject("[email protected]"));
79-
80-
testUser = Instancio.of(modelGenerator.getUserModel())
81-
.create();
79+
testUser = Instancio.of(modelGenerator.getUserModel()).create();
8280
userRepository.save(testUser);
81+
token = jwt().jwt(builder -> builder.subject(testUser.getEmail()));
82+
}
83+
84+
@AfterEach
85+
public void clean() {
86+
userRepository.deleteAll();
8387
}
8488

8589
@Test

0 commit comments

Comments
 (0)