update

Author: fey

.github/workflows/phpci.yaml

@@ -19,9 +19,6 @@ jobs:
       with:
         php-version: '8.4'
 
-    - name: PHP Security Checker
-      uses: StephaneBour/[email protected]
-
     - name: Setup project
       run: make setup
 

src/graphs.php

@@ -29,7 +29,7 @@
  * //   'E' => ['C'],
  * // ]
  */
-function makeJoints(array $tree)
+function makeJoints(array $tree): array
 {
     $iter = function ($tree, $acc, $parent) use (&$iter) {
         $leaf = $tree[0];
@@ -80,7 +80,7 @@ function makeJoints(array $tree)
  * //     ]],
  * // ]];
  */
-function buildTreeFromLeaf(array $joints, string $leaf)
+function buildTreeFromLeaf(array $joints, string $leaf): array
 {
     $iter = function ($current, $acc) use (&$iter, $joints) {
 
@@ -128,7 +128,7 @@ function buildTreeFromLeaf(array $joints, string $leaf)
  * //     E: ['C'],
  * // ]
  */
-function sortJoints(array $joints)
+function sortJoints(array $joints): array
 {
     $sortedJoints = [];
     foreach ($joints as $node => $neighbors) {
@@ -169,7 +169,7 @@ function sortJoints(array $joints)
  * //     ]],
  * // ]];
  */
-function map(callable $func, array $tree)
+function map(callable $func, array $tree): array
 {
     $children = $tree[1] ?? null;
     $updatedName = $func($tree);
@@ -221,7 +221,7 @@ function map(callable $func, array $tree)
  * //     E6, 'E',
  * // ]
  */
-function makeAssociations(array $uniqueTree, array $tree)
+function makeAssociations(array $uniqueTree, array $tree): array
 {
     $uniqueLeafs = collect($uniqueTree)->flatten();
     $leafs = collect($tree)->flatten();
@@ -270,7 +270,7 @@ function makeAssociations(array $uniqueTree, array $tree)
  * //     ['D'],
  * // ]];
  */
-function sortTree(array $tree)
+function sortTree(array $tree): array
 {
     $uniqueTree = map(fn($node) => uniqid($node[0]), $tree);
     $associations = makeAssociations($uniqueTree, $tree);

tests/GraphsTest.php

@@ -12,7 +12,7 @@
 
 class GraphsTest extends TestCase
 {
-    public function testMakeJoints()
+    public function testMakeJoints(): void
     {
         $tree = ['A', [
             ['C', [
@@ -39,28 +39,28 @@ public function testMakeJoints()
         ]];
 
         $expected = [
-          'A' => ['C', 'B', null],
-          'C' => ['F', 'G', 'A'],
-          'F' => ['J', 'I', 'C'],
-          'J' => ['O', 'N', 'F'],
-          'O' => ['J'],
-          'N' => ['J'],
-          'I' => ['M', 'F'],
-          'M' => ['I'],
-          'G' => ['K', 'L', 'C'],
-          'K' => ['G'],
-          'L' => ['G'],
-          'B' => ['E', 'D', 'A'],
-          'E' => ['B'],
-          'D' => ['H', 'B'],
-          'H' => ['D']
+            'A' => ['C', 'B', null],
+            'C' => ['F', 'G', 'A'],
+            'F' => ['J', 'I', 'C'],
+            'J' => ['O', 'N', 'F'],
+            'O' => ['J'],
+            'N' => ['J'],
+            'I' => ['M', 'F'],
+            'M' => ['I'],
+            'G' => ['K', 'L', 'C'],
+            'K' => ['G'],
+            'L' => ['G'],
+            'B' => ['E', 'D', 'A'],
+            'E' => ['B'],
+            'D' => ['H', 'B'],
+            'H' => ['D']
         ];
 
         $actual = makeJoints($tree);
         $this->assertEquals($expected, $actual);
     }
 
-    public function testBuildTreeFromLeaf()
+    public function testBuildTreeFromLeaf(): void
     {
         $joints = [
             'B' => ['D', 'A'],
@@ -86,7 +86,7 @@ public function testBuildTreeFromLeaf()
         $this->assertEquals($expected, $actual);
     }
 
-    public function testSortJoints()
+    public function testSortJoints(): void
     {
         $joints = [
             'B' => ['D', 'A'],
@@ -111,7 +111,7 @@ public function testSortJoints()
         $this->assertEquals($expected, $actual);
     }
 
-    public function testMap()
+    public function testMap(): void
     {
         $tree = ['A', [
             ['C', [
@@ -169,7 +169,7 @@ public function testMap()
         $this->assertEquals($expected, $actual);
     }
 
-    public function testSortTree()
+    public function testSortTree(): void
     {
         $tree = ['B', [
             ['D'],