fix: review

Author: hexqi

.agents/skills/tinyengine-dsl-generator/SKILL.md

@@ -603,7 +603,7 @@ Page file structure (wrapper):
 {
   "name": "PageName",
   "id": "unique-id",
-  "app": "1",
+  "app": 1,
   "route": "page-route",
   "page_content": {
     /* actual page DSL with componentName: "Page" */

.agents/skills/tinyengine-dsl-generator/scripts/check_css.py

@@ -136,7 +136,7 @@ def _check_css(self, css: str) -> bool:
             return len(self.errors) == 0
 
         except Exception as e:
-            self.errors.append(f"Failed to parse CSS: {e}")
+            self.errors.append(f"CSS check failed unexpectedly: {e}")
             return False
 
 
@@ -201,7 +201,10 @@ def _check_css(self, css: str) -> bool:
             import os
             try:
                 os.unlink(temp_file)
-            except:
+            except OSError:
+                # FileNotFoundError (subclass of OSError) is expected if the temp
+                # file was never created or already removed; other OS-level
+                # cleanup failures are non-fatal here.
                 pass
 
 

.agents/skills/tinyengine-dsl-generator/scripts/check_event_bindings.py

@@ -43,9 +43,17 @@ def _check_node(self, node: Any) -> None:
                 self._check_node(item)
 
     def _check_event_bindings(self, node: Dict[str, Any]) -> None:
-        """检查单个节点的事件绑定"""
+        """检查单个节点的事件绑定（含 props 内的事件绑定）"""
         component = node.get('componentName', 'unknown')
 
+        # 两处都需要校验，避免漏检 props 内的事件。
+        self._check_event_holder(node, component)
+        props = node.get('props')
+        if isinstance(props, dict):
+            self._check_event_holder(props, component)
+
+    def _check_event_holder(self, holder: Dict[str, Any], component: str) -> None:
+        """检查某个属性容器（节点本身或其 props）内的事件绑定"""
         # 检查所有可能的事件属性
         event_keys = [
             'onClick', 'onChange', 'onKeyup', 'onKeyDown', 'onKeyPress',
@@ -55,13 +63,13 @@ def _check_event_bindings(self, node: Dict[str, Any]) -> None:
         ]
 
         for key in event_keys:
-            if key in node:
-                value = node[key]
+            if key in holder:
+                value = holder[key]
                 if isinstance(value, dict):
                     self._check_event_value(component, key, value)
 
         # 也检查以'on'开头的属性
-        for key, value in node.items():
+        for key, value in holder.items():
             if key.startswith('on') and key not in event_keys:
                 if isinstance(value, dict):
                     self._check_event_value(component, key, value)

.agents/skills/tinyengine-dsl-generator/scripts/validate_page.py

@@ -95,8 +95,13 @@ def check_class_name_usage(file_path: str) -> bool:
     try:
         with open(file_path, 'r', encoding='utf-8') as f:
             data = json.load(f)
-    except:
-        return True  # JSON 错误会在其他检查中捕获
+    except (json.JSONDecodeError, OSError):
+        # JSON 语法错误或文件读取问题（FileNotFoundError 属于 OSError）由其他
+        # 检查负责报告；此处不掩盖其他意外运行错误。
+        return True
+    except Exception as e:
+        print(f"❌ className 检查异常: {e}")
+        return False
 
     page_content = data.get('page_content', {})
     errors = []

.gitignore

@@ -28,3 +28,4 @@ pnpm-debug.log*
 *.sw?
 tmp
 temp
+__pycache__

mockServer/data/appsSchema/16.json

@@ -863,7 +863,7 @@
                       "componentName": "Text",
                       "props": {
                         "text": "温馨提示：页面左上角切换区域",
-                        "style": "background-color: [object Event]; color: #8a8e99; font-size: 12px;"
+                        "style": "background-color: #f5f5f5; color: #8a8e99; font-size: 12px;"
                       },
                       "id": "20923497"
                     },
@@ -1700,10 +1700,10 @@
         "occupier": {
           "id": 86,
           "username": "开发者",
-          "email": "developer@lowcode_com",
+          "email": "demo@example.com",
           "provider": null,
           "password": null,
-          "confirmationToken": "dfb2c162-351f-4f44-ad5f-899831311129",
+          "confirmationToken": null,
           "confirmed": true,
           "blocked": null,
           "role": null,

mockServer/data/pages/CreateVm.json

@@ -116,7 +116,7 @@
                     "componentName": "Text",
                     "props": {
                       "text": "温馨提示：页面左上角切换区域",
-                      "style": "background-color: [object Event]; color: #8a8e99; font-size: 12px;"
+                      "style": "background-color: #f5f5f5; color: #8a8e99; font-size: 12px;"
                     },
                     "id": "20923497"
                   },

mockServer/scripts/export-db-to-file.js

@@ -10,6 +10,7 @@ const forceOverwrite = process.argv.includes('--force')
 const collectionNamingFields = {
   pages: ['name'],
   apps: ['name'],
+  appsSchema: ['id'],
   blocks: ['label', 'name'],
   blockGroups: ['name'],
   blockCategories: ['name']

mockServer/src/services/apps.js

@@ -85,7 +85,7 @@ export default class AppsService {
       id: mockId++,
       ...params
     }
-    this.store.insert(newApp)
+    await this.store.insert(newApp)
 
     let resultStr = JSON.stringify(defaultAppSchema.data)
     resultStr = resultStr.replace(/"lowcode./g, '"lowcode_')
@@ -102,7 +102,19 @@ export default class AppsService {
       },
       id: newApp.id
     }
-    this.schemaStore.insert(newAppSchema)
+    // App and schema live in different collections. If the schema write fails,
+    // best-effort roll back the app insert so we don't leave a one-sided record,
+    // then rethrow — ErrorRoutesCatch serializes thrown errors into the response.
+    try {
+      await this.schemaStore.insert(newAppSchema)
+    } catch (err) {
+      try {
+        await this.store.remove({ id: newApp.id })
+      } catch {
+        /* swallow cleanup failure; surface the original error below */
+      }
+      throw err
+    }
     return getResponseData(newApp)
   }
 

mockServer/src/services/block.js

@@ -22,8 +22,8 @@ export default class BlockService {
     this.userInfo = {
       id: 86,
       username: '开发者',
-      email: 'developer@lowcode.com',
-      confirmationToken: 'dfb2c162-351f-4f44-ad5f-8998',
+      email: 'demo@example.com',
+      confirmationToken: null,
       is_admin: true
     }