fix: preserve API settings and report env write failures

Author: hgmzhn

desktop_qt_ui/locales/en_US.json

@@ -1298,6 +1298,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "Skip only when OCR text exactly matches one of these rules.",
   "Warning": "Warning",
   "Error": "Error",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.",
   "Filter:": "Filter:",
   "Type to filter by pattern / replace / comment...": "Type to filter by pattern / replace / comment...",
   "Selection": "Selection",

desktop_qt_ui/locales/es_ES.json

@@ -1289,6 +1289,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "Omitir solo cuando el texto OCR coincida exactamente con una de estas reglas.",
   "Warning": "Advertencia",
   "Error": "Error",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "No se pudo guardar la configuración. Los cambios no se guardaron. Compruebe los permisos del archivo y si el antivirus o el software de seguridad está bloqueando el acceso.",
   "Filter:": "Filtrar:",
   "Type to filter by pattern / replace / comment...": "Escriba para filtrar por patrón / reemplazo / comentario...",
   "Selection": "Selección",

desktop_qt_ui/locales/ja_JP.json

@@ -1289,6 +1289,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "OCR テキストが以下のいずれかと完全一致する場合のみ、そのテキスト領域をスキップします。",
   "Warning": "警告",
   "Error": "エラー",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "設定の保存に失敗し、変更は保存されませんでした。ファイルのアクセス権限、およびウイルス対策・セキュリティソフトによるアクセス遮断を確認してください。",
   "Filter:": "フィルター:",
   "Type to filter by pattern / replace / comment...": "パターン / 置換 / コメントで絞り込み...",
   "Selection": "選択範囲",

desktop_qt_ui/locales/ko_KR.json

@@ -1289,6 +1289,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "OCR 텍스트가 아래 규칙 중 하나와 완전히 일치할 때만 해당 텍스트 영역을 건너뜁니다.",
   "Warning": "경고",
   "Error": "오류",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "구성 저장에 실패하여 변경 사항이 저장되지 않았습니다. 파일 권한 및 백신 또는 보안 소프트웨어의 접근 차단 여부를 확인하세요.",
   "Filter:": "필터:",
   "Type to filter by pattern / replace / comment...": "패턴 / 치환 / 주석으로 필터링하려면 입력...",
   "Selection": "선택 영역",

desktop_qt_ui/locales/zh_CN.json

@@ -1298,6 +1298,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "仅当 OCR 文本与以下某条规则完全一致时跳过该文本区域。",
   "Warning": "警告",
   "Error": "错误",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "配置保存失败，修改未保存。请检查文件权限，以及杀毒软件或安全软件是否拦截了文件访问。",
   "Filter:": "过滤:",
   "Type to filter by pattern / replace / comment...": "输入匹配 / 替换 / 备注以过滤...",
   "Selection": "选区",

desktop_qt_ui/locales/zh_TW.json

@@ -1291,6 +1291,7 @@
   "Skip only when OCR text exactly matches one of these rules.": "僅當 OCR 文字與以下某條規則完全一致時跳過該文字區域。",
   "Warning": "警告",
   "Error": "錯誤",
+  "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access.": "設定儲存失敗，變更未儲存。請檢查檔案權限，以及防毒軟體或安全軟體是否攔截了檔案存取。",
   "Filter:": "過濾:",
   "Type to filter by pattern / replace / comment...": "輸入匹配 / 替換 / 備註以過濾...",
   "Selection": "選區",

desktop_qt_ui/services/config_service.py

@@ -33,6 +33,7 @@
     format_env_line,
     load_app_dotenv,
     read_dotenv_file,
+    remove_invalid_dotenv_lines,
     validate_env_key,
 )
 from manga_translator.utils.openai_compat import resolve_openai_compatible_api_key
@@ -159,6 +160,8 @@ def __init__(self, root_dir: str):
         else:
             self.env_path = os.path.join(self.root_dir, ".env")
         os.environ[APP_DOTENV_PATH_ENV] = self.env_path
+        self._deferred_write_error: Optional[str] = None
+        self._remove_invalid_env_lines()
         try:
             self._env_values = read_dotenv_file(self.env_path)
             load_app_dotenv(self.env_path, override=True)
@@ -201,6 +204,22 @@ def __init__(self, root_dir: str):
         self._config_cache = None
         self._initialize_write_pipeline()
 
+    def _remove_invalid_env_lines(self) -> None:
+        try:
+            removed = remove_invalid_dotenv_lines(self.env_path)
+        except Exception as exc:
+            self._deferred_write_error = f"{self.env_path}: {exc}"
+            self.logger.error(f"清理 .env 解析错误行失败: {exc}")
+            return
+        if removed:
+            self.logger.warning(f"已删除 .env 中 {removed} 行无法解析的配置")
+
+    def take_deferred_write_error(self) -> Optional[str]:
+        error = self._deferred_write_error
+        self._deferred_write_error = None
+        return error
+
+
     def _initialize_write_pipeline(self) -> None:
         self._write_lock = threading.RLock()
         self._pending_config_writes: Dict[str, Dict[str, Any]] = {}
@@ -654,7 +673,7 @@ def on_done(done_future: Future) -> None:
                     message,
                     exc_info=(type(error), error, error.__traceback__),
                 )
-                self.write_failed.emit(message)
+                self.write_failed.emit(str(error))
 
         future.add_done_callback(on_done)
         return future
@@ -704,6 +723,7 @@ def reload_config(self):
         """
         self.logger.info("正在强制重新加载配置...")
         self.flush_pending_writes()
+        self._remove_invalid_env_lines()
 
         # 1. 重新加载 .env 文件到 os.environ。翻译引擎会自动从此读取。
         load_app_dotenv(self.env_path, override=True)

desktop_qt_ui/ui/main_page/env_management.py

@@ -843,9 +843,17 @@ def flush_env_var_immediately(self, key: str):
 
 
 def flush_all_pending_env_vars(self, wait: bool = True):
-    """显式 API/预设操作可等待 ConfigService 原子落盘。"""
-    config_service = getattr(self.controller, 'config_service', None)
-    flush = getattr(config_service, 'flush_pending_writes', None)
+    """先提交当前控件值，再按需等待 ConfigService 原子落盘。"""
+    config_service = getattr(self.controller, "config_service", None)
+    save_many = getattr(config_service, "save_env_vars", None)
+    if callable(save_many):
+        visible_values = {
+            key: _get_env_widget_value(widget)
+            for key, (_label, widget) in getattr(self, "env_widgets", {}).items()
+        }
+        if visible_values:
+            save_many(visible_values)
+    flush = getattr(config_service, "flush_pending_writes", None)
     if wait and callable(flush):
         flush()
 

desktop_qt_ui/ui/main_window.py

@@ -452,6 +452,16 @@ def _connect_signals(self):
         self.app_logic.warning_dialog_requested.connect(
             self._show_warning_dialog, type=Qt.ConnectionType.QueuedConnection
         )
+        self.config_service.write_failed.connect(
+            self._show_config_write_failed,
+            type=Qt.ConnectionType.QueuedConnection,
+        )
+        deferred_write_error = self.config_service.take_deferred_write_error()
+        if deferred_write_error:
+            QTimer.singleShot(
+                0,
+                lambda error=deferred_write_error: self._show_config_write_failed(error),
+            )
         self.file_list_data_service.loading.connect(
             self._on_main_catalog_loading,
             type=Qt.ConnectionType.QueuedConnection,
@@ -467,6 +477,7 @@ def _connect_signals(self):
 
         # --- View to Logic Connections ---
         self.main_view.setting_changed.connect(self.app_logic.update_single_config)
+        self.main_view.env_var_changed.connect(self.app_logic.save_env_var)
         self.main_view.editor_view_requested.connect(self.switch_to_editor_view)
         self.main_view.theme_change_requested.connect(self._change_theme)
         self.main_view.language_change_requested.connect(
@@ -812,6 +823,22 @@ def _show_warning_dialog(self, message: str):
         except Exception as e:
             self.logger.error(f"_show_warning_dialog error: {e}", exc_info=True)
 
+    @pyqtSlot(str)
+    def _show_config_write_failed(self, error: str):
+        """明确提示配置写入失败，避免用户误以为 API Key 已保存。"""
+        try:
+            guidance = self._t(
+                "Configuration save failed. Changes were not saved. Check file permissions and antivirus or security software blocking access."
+            )
+            detail = str(error or "").strip()
+            message = f"{guidance}\n\n{detail}" if detail else guidance
+            show_error_dialog(self, self._t("Error"), "", message)
+        except Exception as exc:
+            self.logger.error(
+                f"_show_config_write_failed error: {exc}", exc_info=True
+            )
+
+
     def switch_to_editor_view(self):
         """
         Simply switches to the editor view without reloading file lists.

manga_translator/utils/dotenv_utils.py

@@ -6,6 +6,7 @@
 
 import os
 import re
+import tempfile
 from pathlib import Path
 from typing import Dict, Mapping, Optional, Union
 
@@ -61,6 +62,49 @@ def read_dotenv_file(path: PathLike) -> Dict[str, str]:
     }
 
 
+def remove_invalid_dotenv_lines(path: PathLike) -> int:
+    """Delete statements that python-dotenv cannot parse, preserving valid content."""
+    env_path = Path(path)
+    if not env_path.exists():
+        return 0
+
+    lines: list[str] = []
+    removed = 0
+    with env_path.open("r", encoding="utf-8") as source:
+        for mapping in parse_stream(source):
+            if mapping.error:
+                removed += 1
+                continue
+            lines.append(mapping.original.string)
+
+    if removed:
+        temp_path: str | None = None
+        try:
+            with tempfile.NamedTemporaryFile(
+                mode="w",
+                encoding="utf-8",
+                newline="",
+                dir=env_path.parent,
+                prefix=f".{env_path.name}.",
+                suffix=".tmp",
+                delete=False,
+            ) as temp_file:
+                temp_path = temp_file.name
+                temp_file.write("".join(lines))
+                temp_file.flush()
+                os.fsync(temp_file.fileno())
+            os.replace(temp_path, env_path)
+            temp_path = None
+        finally:
+            if temp_path:
+                try:
+                    os.remove(temp_path)
+                except OSError:
+                    pass
+    return removed
+
+
+
 def load_app_dotenv(
     dotenv_path: Optional[PathLike] = None,
     *,