fix: keep background update checks quiet

Author: hgmzhn

desktop_qt_ui/core/git_update_helpers.py

@@ -30,17 +30,19 @@ def git_executable(root: Path) -> str:
         return str(portable_git)
     return os.environ.get("GIT") or shutil.which("git") or "git"
 
+_GIT_CREATION_FLAGS = subprocess.CREATE_NO_WINDOW if os.name == "nt" else 0
 
-def git_output(
+
+def _run_git(
     root: Path,
     args: list[str],
     *,
-    timeout: float = 15,
+    timeout: float,
     executable: str | None = None,
-) -> str | None:
-    """Run a Git read command and return trimmed stdout on success."""
+) -> subprocess.CompletedProcess[str] | None:
+    """Run Git without creating a console window in the desktop application."""
     try:
-        result = subprocess.run(
+        return subprocess.run(
             [executable or git_executable(root), *args],
             cwd=root,
             capture_output=True,
@@ -49,10 +51,22 @@ def git_output(
             timeout=timeout,
             encoding="utf-8",
             errors="ignore",
+            creationflags=_GIT_CREATION_FLAGS,
         )
     except (OSError, subprocess.SubprocessError):
         return None
-    if result.returncode != 0:
+
+
+def git_output(
+    root: Path,
+    args: list[str],
+    *,
+    timeout: float = 15,
+    executable: str | None = None,
+) -> str | None:
+    """Run a Git read command and return trimmed stdout on success."""
+    result = _run_git(root, args, timeout=timeout, executable=executable)
+    if result is None or result.returncode != 0:
         return None
     return result.stdout.strip()
 
@@ -70,20 +84,13 @@ def remote_url(root: Path, *, executable: str | None = None) -> str:
 
 def set_origin_url(root: Path, url: str, *, executable: str | None = None) -> bool:
     """Persist a new origin URL for both the UI and maintenance launcher."""
-    try:
-        result = subprocess.run(
-            [executable or git_executable(root), "remote", "set-url", "origin", url],
-            cwd=root,
-            capture_output=True,
-            text=True,
-            check=False,
-            timeout=15,
-            encoding="utf-8",
-            errors="ignore",
-        )
-    except (OSError, subprocess.SubprocessError):
-        return False
-    return result.returncode == 0
+    result = _run_git(
+        root,
+        ["remote", "set-url", "origin", url],
+        timeout=15,
+        executable=executable,
+    )
+    return result is not None and result.returncode == 0
 
 
 def mirror_index(url: str) -> int:
@@ -132,20 +139,13 @@ def fetch_origin(
     executable: str | None = None,
 ) -> bool:
     """Fetch one origin branch, returning whether the remote ref is current."""
-    try:
-        result = subprocess.run(
-            [executable or git_executable(root), "fetch", "origin", branch],
-            cwd=root,
-            capture_output=True,
-            text=True,
-            check=False,
-            timeout=timeout,
-            encoding="utf-8",
-            errors="ignore",
-        )
-    except (OSError, subprocess.SubprocessError):
-        return False
-    return result.returncode == 0
+    result = _run_git(
+        root,
+        ["fetch", "origin", branch],
+        timeout=timeout,
+        executable=executable,
+    )
+    return result is not None and result.returncode == 0
 
 
 def current_commit(root: Path, *, short: bool = False, executable: str | None = None) -> str:

desktop_qt_ui/services/update_service.py

@@ -34,11 +34,10 @@ class UpdateInfo:
 
     @property
     def is_update_available(self) -> bool:
-        versions_are_valid = bool(
-            _version_parts(self.latest_version) and _version_parts(self.current_version)
-        )
-        version_update = versions_are_valid and (
-            compare_versions(self.latest_version, self.current_version) >= 0
+        version_update = (
+            bool(_version_parts(self.latest_version))
+            and bool(_version_parts(self.current_version))
+            and compare_versions(self.latest_version, self.current_version) > 0
         )
         commit_update = self.commits_behind > 0
         return version_update or commit_update

desktop_qt_ui/ui/main_page/view.py

@@ -171,7 +171,7 @@ def __init__(self, controller, parent=None):
         self.controller.state_manager.current_config_changed.connect(self.update_start_button_text)
         QTimer.singleShot(100, self.update_start_button_text) # Set initial text
         QTimer.singleShot(100, self._sync_workflow_mode_from_config) # Sync workflow mode dropdown
-        QTimer.singleShot(1500, self._maybe_auto_check_updates)
+        QTimer.singleShot(5000, self._maybe_auto_check_updates)
 
     def _create_translation_interface(self, translation_page: QWidget) -> QWidget:
         interface = QWidget()

test/test_update_service.py

@@ -1,6 +1,7 @@
 import _bootstrap  # noqa: F401, I001
 import builtins
 import importlib.util
+from desktop_qt_ui.core import git_update_helpers
 from services import update_service
 from services.update_service import UpdateInfo, compare_versions
 
@@ -26,12 +27,26 @@ def test_compare_versions_handles_v_prefix_and_missing_patch_parts():
     assert compare_versions("2.1.99", "2.2") == -1
 
 
-def test_update_info_reports_same_or_newer_release_as_available():
+def test_git_commands_use_no_window_creation_flags(monkeypatch, tmp_path):
+    captured = {}
+
+    def fake_run(args, **kwargs):
+        captured.update(kwargs)
+        return git_update_helpers.subprocess.CompletedProcess(args, 0, "ok\n", "")
+
+    monkeypatch.setattr(git_update_helpers.subprocess, "run", fake_run)
+    monkeypatch.setattr(git_update_helpers, "_GIT_CREATION_FLAGS", 0x08000000)
+
+    assert git_update_helpers.git_output(tmp_path, ["status"], executable="git") == "ok"
+    assert captured["creationflags"] == 0x08000000
+
+
+def test_update_info_reports_only_newer_release_as_available():
     newer = UpdateInfo("2.2.10", "2.2.11", "https://example.test", "", "")
     same = UpdateInfo("2.2.10", "2.2.10", "https://example.test", "", "")
     unknown = UpdateInfo("unknown", "unknown", "https://example.test", "", "")
     assert newer.is_update_available
-    assert same.is_update_available
+    assert not same.is_update_available
     assert not unknown.is_update_available