fix lint (unused variables)

Author: jjergus

src/PartiallyGeneratedCode.hack

@@ -126,7 +126,7 @@ final class PartiallyGeneratedCode {
    * manual sections, duplicated ids, etc)
    */
   public function assertValidManualSections(): void {
-    foreach ($this->iterateCodeSections($this->code) as $section) {
+    foreach ($this->iterateCodeSections($this->code) as $_section) {
     }
   }
 
@@ -141,14 +141,12 @@ final class PartiallyGeneratedCode {
     string $code,
   ): \Generator<int, (?string, string), void> {
     // Regular expression to match the beginning of a manual section
-    $quoted = \preg_quote(self::$manualBegin, '/');
     $begin = self::getBeginManualSectionRegex('(.*)');
     $valid_begin = self::getBeginManualSectionRegex('([A-Za-z0-9:_]+)');
 
     $seen_ids = keyset[];
     $current_id = null;
     $chunk = array();
-    $manual = array();
     $lines = \explode("\n", $code);
     foreach ($lines as $line) {
       if (\strpos($line, self::$manualEnd) !== false) {

tests/CodegenFileTest.hack

@@ -143,21 +143,18 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testSaveAutogenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->saveAutogeneratedFile();
     expect_with_context(static::class, Filesystem::readFile($fname))->toBeUnchanged();
   }
 
   public function testClobberManuallyWrittenCode(): void {
-    $cgf = $this->getCodegenFactory();
     expect(() ==> {
       $fname = $this->saveManuallyWrittenFile();
       $this->saveAutogeneratedFile($fname);
     })->toThrow(CodegenFileNoSignatureException::class);
   }
 
   public function testReSaveAutogenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->saveAutogeneratedFile();
     $content0 = Filesystem::readFile($fname);
     $this->saveAutogeneratedFile($fname);
@@ -166,7 +163,6 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testSaveModifiedAutogenerated(): void {
-    $cgf = $this->getCodegenFactory();
     expect(() ==> {
       $fname = $this->saveAutogeneratedFile();
       $content = Filesystem::readFile($fname);
@@ -177,7 +173,6 @@ final class CodegenFileTest extends CodegenBaseTest {
 
 
   public function testSavePartiallyGenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->savePartiallyGeneratedFile();
     $content = Filesystem::readFile($fname);
     expect_with_context(static::class, $content)->toBeUnchanged();
@@ -187,7 +182,6 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testReSavePartiallyGenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->savePartiallyGeneratedFile();
     $content0 = Filesystem::readFile($fname);
     $this->savePartiallyGeneratedFile($fname);
@@ -196,7 +190,6 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testSaveModifiedWrongPartiallyGenerated(): void {
-    $cgf = $this->getCodegenFactory();
     expect(() ==> {
       $fname = $this->savePartiallyGeneratedFile();
       $content = Filesystem::readFile($fname);
@@ -222,7 +215,6 @@ final class CodegenFileTest extends CodegenBaseTest {
    * Test modifying a manual section and saving.
    */
   public function testSaveModifiedManualSectionPartiallyGenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->createAndModifyPartiallyGeneratedFile();
     $this->savePartiallyGeneratedFile($fname);
     $content = Filesystem::readFile($fname);
@@ -234,7 +226,6 @@ final class CodegenFileTest extends CodegenBaseTest {
    * that the generated part is different too.
    */
   public function testSaveModifyPartiallyGenerated(): void {
-    $cgf = $this->getCodegenFactory();
     $fname = $this->createAndModifyPartiallyGeneratedFile();
     $this->savePartiallyGeneratedFile($fname, true);
     $content = Filesystem::readFile($fname);
@@ -318,16 +309,13 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testNoShebangInStrict(): void {
-    expect(() ==> {
-      $cgf = $this->getCodegenFactory();
-      $code = $cgf
-      ->codegenFile('no_file')
-      ->setFileType(CodegenFileType::HACK_STRICT)
-      ->setShebangLine('#!/usr/bin/env hhvm')
-      ->render();
-    })->toThrow(      /* HH_FIXME[2049] no hhi for invariantexception */
-      \HH\InvariantException::class,
-);
+    expect(
+      () ==> $this->getCodegenFactory()
+        ->codegenFile('no_file')
+        ->setFileType(CodegenFileType::HACK_STRICT)
+        ->setShebangLine('#!/usr/bin/env hhvm')
+        ->render(),
+    )->toThrow(\HH\InvariantException::class);
   }
 
   public function testDotHackExecutable(): void {
@@ -347,29 +335,23 @@ final class CodegenFileTest extends CodegenBaseTest {
   }
 
   public function testNoPseudoMainHeaderInStrict(): void {
-    expect(() ==> {
-      $cgf = $this->getCodegenFactory();
-      $code = $cgf
-      ->codegenFile('no_file')
-      ->setFileType(CodegenFileType::HACK_STRICT)
-      ->setPseudoMainHeader('exit();')
-      ->render();
-    })->toThrow(      /* HH_FIXME[2049] no hhi for invariantexception */
-      \HH\InvariantException::class,
-);
+    expect(
+      () ==> $this->getCodegenFactory()
+        ->codegenFile('no_file')
+        ->setFileType(CodegenFileType::HACK_STRICT)
+        ->setPseudoMainHeader('exit();')
+        ->render(),
+    )->toThrow(\HH\InvariantException::class);
   }
 
   public function testNoPseudoMainFooterInStrict(): void {
-    expect(() ==> {
-      $cgf = $this->getCodegenFactory();
-      $code = $cgf
-      ->codegenFile('no_file')
-      ->setFileType(CodegenFileType::HACK_STRICT)
-      ->setPseudoMainFooter('exit();')
-      ->render();
-    })->toThrow(      /* HH_FIXME[2049] no hhi for invariantexception */
-      \HH\InvariantException::class,
-);
+    expect(
+      () ==> $this->getCodegenFactory()
+        ->codegenFile('no_file')
+        ->setFileType(CodegenFileType::HACK_STRICT)
+        ->setPseudoMainFooter('exit();')
+        ->render(),
+    )->toThrow(\HH\InvariantException::class);
   }
 
   public function testFormattingFullyGeneratedFile(): void {