Lint away final methods in final classes (#121)

Author: lexidor

src/CodegenClass.hack

@@ -85,7 +85,7 @@ final class CodegenClass extends CodegenClassish {
    *
    * @param $comment the full comment, including delimiters
    */
-  final public function addDeclComment(string $comment): this {
+  public function addDeclComment(string $comment): this {
     $this->declComment .= $comment."\n";
     return $this;
   }

src/key-value-render/HackBuilderClassnameRenderer.hack

@@ -19,7 +19,7 @@ final class HackBuilderClassnameRenderer
   implements
     IHackBuilderKeyRenderer<string>,
     IHackBuilderValueRenderer<string> {
-  final public function render(IHackCodegenConfig $_, string $value): string {
+  public function render(IHackCodegenConfig $_, string $value): string {
     return "\\".$value.'::class';
   }
 }

src/key-value-render/HackBuilderCodeRenderer.hack

@@ -19,7 +19,7 @@ use type Facebook\HackCodegen\{
 final class HackBuilderCodeRenderer
 implements IHackBuilderValueRenderer<HackBuilder> {
 
-  final public function render(
+  public function render(
     IHackCodegenConfig $_,
     HackBuilder $value,
   ): string {

src/key-value-render/HackBuilderCodegenRenderer.hack

@@ -20,7 +20,7 @@ use type Facebook\HackCodegen\{
 final class HackBuilderCodegenRenderer
 implements IHackBuilderValueRenderer<ICodeBuilderRenderer> {
 
-  final public function render(
+  public function render(
     IHackCodegenConfig $config,
     ICodeBuilderRenderer $value,
   ): string {

src/key-value-render/HackBuilderKeyExportRenderer.hack

@@ -16,7 +16,7 @@ use type Facebook\HackCodegen\{
 
 final class HackBuilderKeyExportRenderer
   implements IHackBuilderKeyRenderer<arraykey> {
-  final public function render(IHackCodegenConfig $_, arraykey $value): string {
+  public function render(IHackCodegenConfig $_, arraykey $value): string {
     return normalized_var_export($value);
   }
 }

src/key-value-render/HackBuilderKeyLambdaRenderer.hack

@@ -21,7 +21,7 @@ final class HackBuilderKeyLambdaRenderer<T as arraykey>
   ) {
   }
 
-  final public function render(IHackCodegenConfig $config, T $value): string {
+  public function render(IHackCodegenConfig $config, T $value): string {
     $callback = $this->callback;
     return $callback($config, $value);
   }

src/key-value-render/HackBuilderLiteralRenderer.hack

@@ -19,7 +19,7 @@ final class HackBuilderLiteralRenderer
   implements
     IHackBuilderKeyRenderer<string>,
     IHackBuilderValueRenderer<string> {
-  final public function render(IHackCodegenConfig $_, string $value): string {
+  public function render(IHackCodegenConfig $_, string $value): string {
     return $value;
   }
 }

src/key-value-render/HackBuilderNativeKeyValueCollectionRenderer.hack

@@ -29,7 +29,7 @@ final class HackBuilderNativeKeyValueCollectionRenderer<
   ) {
   }
 
-  final public function render(IHackCodegenConfig $config, T $values): string {
+  public function render(IHackCodegenConfig $config, T $values): string {
     $key_renderer = $this->keyRenderer;
     $value_renderer = $this->valueRenderer;
 

src/key-value-render/HackBuilderRegexRenderer.hack

@@ -16,7 +16,7 @@ use namespace HH\Lib\{Regex, Str};
 final class HackBuilderRegexRenderer<T>
   implements IHackBuilderValueRenderer<Regex\Pattern<T>> {
 
-  final public function render(
+  public function render(
     IHackCodegenConfig $_,
     Regex\Pattern<T> $value,
   ): string {

src/key-value-render/HackBuilderShapeRenderer.hack

@@ -23,7 +23,7 @@ final class HackBuilderShapeRenderer
   ) {
   }
 
-  final public function render(
+  public function render(
     IHackCodegenConfig $config,
     shape(/* HH_FIXME[0003] */...) $shape,
   ): string {