Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Commit 8147bbb

Browse files
committed
Add HH_IGNORE_ERROR for usage of new shape syntax in 3.21
1 parent 3240ca8 commit 8147bbb

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/key-value-render/HackBuilderShapeRenderer.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@
1212
namespace Facebook\HackCodegen;
1313

1414
final class HackBuilderShapeRenderer
15-
implements IHackBuilderValueRenderer<shape(...)> {
16-
public function __construct(private shape(...) $valueRenderers) {
15+
implements IHackBuilderValueRenderer<shape(/* HH_IGNORE_ERROR[0003] */...)> {
16+
public function __construct(
17+
private shape(/* HH_IGNORE_ERROR[0003] */...) $valueRenderers
18+
) {
1719
}
1820

1921
final public function render(
2022
IHackCodegenConfig $config,
21-
shape(...) $shape,
23+
shape(/* HH_IGNORE_ERROR[0003] */...) $shape,
2224
): string {
2325
$key_renderer = HackBuilderKeys::export();
2426
$value_renderers = Shapes::toArray($this->valueRenderers);

src/key-value-render/HackBuilderValues.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public static function dict<Tk as arraykey, Tv>(
124124

125125
public static function shapeWithUniformRendering<Tv>(
126126
IHackBuilderValueRenderer<Tv> $vr,
127-
): IHackBuilderValueRenderer<shape(...)> {
127+
): IHackBuilderValueRenderer<shape(/* HH_IGNORE_ERROR[0003] */...)> {
128128
/* HH_IGNORE_ERROR[4110] munging array to shape */
129129
return new HackBuilderNativeKeyValueCollectionRenderer(
130130
ContainerType::SHAPE_TYPE,
@@ -134,8 +134,8 @@ public static function shapeWithUniformRendering<Tv>(
134134
}
135135

136136
public static function shapeWithPerKeyRendering(
137-
shape(...) $value_renderers,
138-
): IHackBuilderValueRenderer<shape(...)> {
137+
shape(/* HH_IGNORE_ERROR[0003] */...) $value_renderers,
138+
): IHackBuilderValueRenderer<shape(/* HH_IGNORE_ERROR[0003] */...)> {
139139
return new HackBuilderShapeRenderer($value_renderers);
140140
}
141141

0 commit comments

Comments
 (0)