instanceof -> is

Author: fredemmott

.travis.yml

@@ -2,7 +2,7 @@ sudo: required
 language: generic
 services: docker
 env:
-- HHVM_VERSION=4.1-latest
+- HHVM_VERSION=4.13-latest
 - HHVM_VERSION=latest
 - HHVM_VERSION=nightly
 install:

composer.json

@@ -3,7 +3,7 @@
     "description": "Hack Codegen is a library for programatically generating Hack code",
     "keywords": ["code generation", "Hack"],
     "require": {
-        "hhvm": "^4.1.0",
+        "hhvm": "^4.13.0",
         "hhvm/hhvm-autoload": "^2.0",
         "hhvm/hsl": "^4.0"
     },

src/CodegenFunctionish.hack

@@ -191,7 +191,7 @@ abstract class CodegenFunctionish implements ICodeBuilderRenderer {
 
   protected function getMaxCodeLength(): int {
     $max_length = $this->config->getMaxLineLength();
-    if ($this instanceof CodegenMethodish) {
+    if ($this is CodegenMethodish) {
       $max_length -= $this->config->getSpacesPerIndentation();
     }
     return $max_length;

src/CodegenMethodish.hack

@@ -50,7 +50,7 @@ abstract class CodegenMethodish extends CodegenFunctionish
 
   public function setContainingClass(CodegenClassish $class): this {
     $this->containingClass = $class;
-    if ($this->containingClass instanceof CodegenInterface) {
+    if ($this->containingClass is CodegenInterface) {
       $this->isAbstract = true;
     }
     return $this;
@@ -63,7 +63,7 @@ abstract class CodegenMethodish extends CodegenFunctionish
       ->addIf($this->isFinal && !$this->isAbstract, 'final ')
       ->addIf(
         $this->isAbstract &&
-        !($this->containingClass instanceof CodegenInterface),
+        !($this->containingClass is CodegenInterface),
         'abstract ',
       )
       ->add($this->getVisibility().' ')

src/CodegenShapeMember.hack

@@ -37,7 +37,7 @@
    }
 
    public function getType(): string {
-     if ($this->type instanceof ICodeBuilderRenderer) {
+     if ($this->type is ICodeBuilderRenderer) {
        return $this->type->render();
      }
 

src/key-value-render/HackBuilderShapeRenderer.hack

@@ -40,7 +40,7 @@ final class HackBuilderShapeRenderer
         $key,
       );
       invariant(
-        $value_renderer instanceof IHackBuilderValueRenderer,
+        $value_renderer is IHackBuilderValueRenderer<_>,
         'Value renderer for key "%s" is of type "%s", which is not a %s',
         $key,
         \is_object($value_renderer)