RFC/Proof-of-concept: Implement children declarations as a trait (#214)

* RFC: Implement children declarations as a trait

Currently serializes to the same format as HackC, to allow migrating to
the new syntax with no changes to validation.

Some normalization is needed, as HackC emits some overly-complex
structures - e.g. with `$expr = tuple(EXACTLY_ONE, EXPRESSION, $inner_expr)`
can be simplified to `$expr = $inner_expr`.

It is not currently in a form suitable for use - the trait I've added
merely confirms that the two forms of children declaration are
semanticaly equivalent.

I think that's a meaningful first step; if we're happy for this, we can
merge it, start on migration tools, then add an alternative trait to
allow removal of the legacy syntax.

This is very much a draft API; open to a complete rewrite if desired :)

refs #212

* make child declaration a static method

* rename trait for consistency, add new-way-only trait too

* remove bogus child declaration

Author: fredemmott

src/children/Any.hack

@@ -0,0 +1,20 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+final class Any implements Constraint {
+  public function legacySerialize(): mixed {
+    return 1;
+  }
+
+  public function legacySerializeAsLeaf(): (LegacyConstraintType, mixed) {
+    return tuple(LegacyConstraintType::ANY, null);
+  }
+}

src/children/AnyNumberOf.hack

@@ -0,0 +1,15 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+final class AnyNumberOf<T as Constraint> extends QuantifierConstraint<T> {
+  const LegacyExpressionType LEGACY_EXPRESSION_TYPE =
+    LegacyExpressionType::ANY_QUANTITY;
+}

src/children/AnyOf.hack

@@ -0,0 +1,41 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+use namespace HH\Lib\{C, Vec};
+
+final class AnyOf<T as Constraint> implements LegacyExpression {
+  private vec<T> $children;
+  public function __construct(T $a, T $b, T ...$rest) {
+    $this->children = Vec\concat(vec[$a, $b], $rest);
+  }
+
+  public function legacySerialize(): (LegacyExpressionType, mixed, mixed) {
+    $it = tuple(
+      LegacyExpressionType::EITHER,
+      $this->children[0]->legacySerialize(),
+      $this->children[1]->legacySerialize(),
+    );
+    $rest = Vec\drop($this->children, 2);
+    while (!C\is_empty($rest)) {
+      $it = tuple(
+        LegacyExpressionType::EITHER,
+        $it,
+        $rest[0]->legacySerialize(),
+      );
+      $rest = Vec\drop($rest, 1);
+    }
+    return $it;
+  }
+
+  final public function legacySerializeAsLeaf(): null {
+    return null;
+  }
+}

src/children/AtLeastOneOf.hack

@@ -0,0 +1,15 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+final class AtLeastOneOf<T as Constraint> extends QuantifierConstraint<T> {
+  const LegacyExpressionType LEGACY_EXPRESSION_TYPE =
+    LegacyExpressionType::AT_LEAST_ONE;
+}

src/children/Category.hack

@@ -0,0 +1,27 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+use namespace HH\Lib\Str;
+
+final class Category extends LeafConstraint {
+  public function __construct(private string $category) {
+  }
+
+  public function legacySerializeAsLeaf(): (LegacyConstraintType, string) {
+    return tuple(
+      LegacyConstraintType::CATEGORY,
+      $this->category
+        |> Str\strip_prefix($$, '%')
+        |> Str\replace($$, ':', '__')
+        |> Str\replace($$, '-', '_'),
+    );
+  }
+}

src/children/Constraint.hack

@@ -0,0 +1,15 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+interface Constraint {
+  public function legacySerialize(): mixed;
+  public function legacySerializeAsLeaf(): ?(LegacyConstraintType, mixed);
+}

src/children/LeafConstraint.hack

@@ -0,0 +1,21 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+abstract class LeafConstraint implements LegacyExpression {
+  abstract public function legacySerializeAsLeaf(
+  ): (LegacyConstraintType, mixed);
+
+  final public function legacySerialize(
+  ): (LegacyExpressionType, LegacyConstraintType, mixed) {
+    $as_leaf = $this->legacySerializeAsLeaf();
+    return tuple(LegacyExpressionType::EXACTLY_ONE, $as_leaf[0], $as_leaf[1]);
+  }
+}

src/children/LegacyConstraintType.hack

@@ -0,0 +1,18 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+enum LegacyConstraintType: int {
+  ANY = 1;
+  PCDATA = 2;
+  CLASSNAME = 3;
+  CATEGORY = 4;
+  EXPRESSION = 5;
+}

src/children/LegacyExpression.hack

@@ -0,0 +1,14 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+interface LegacyExpression extends Constraint {
+  public function legacySerialize(): (LegacyExpressionType, mixed, mixed);
+}

src/children/LegacyExpressionType.hack

@@ -0,0 +1,19 @@
+/*
+ *  Copyright (c) 2004-present, Facebook, Inc.
+ *  All rights reserved.
+ *
+ *  This source code is licensed under the MIT license found in the
+ *  LICENSE file in the root directory of this source tree.
+ *
+ */
+
+namespace Facebook\XHP\ChildValidation;
+
+enum LegacyExpressionType: int {
+  EXACTLY_ONE = 0;
+  ANY_QUANTITY = 1;
+  ZERO_OR_ONE = 2;
+  AT_LEAST_ONE = 3;
+  SEQUENCE = 4;
+  EITHER = 5;
+}