test: keep browser e2e app-focused

Author: hi-ogawa-agent

.github/workflows/ci.yml

@@ -70,11 +70,11 @@ jobs:
 
       - run: |
           pnpm cli-separate-v2 \
-            fixtures/sine-2s.wav data/output-split
-          test -s data/output-split/drums.wav
-          test -s data/output-split/bass.wav
-          test -s data/output-split/other.wav
-          test -s data/output-split/vocals.wav
+            fixtures/sine-2s.wav data/ci-split-output
+          test -s data/ci-split-output/drums.wav
+          test -s data/ci-split-output/bass.wav
+          test -s data/ci-split-output/other.wav
+          test -s data/ci-split-output/vocals.wav
 
       - run: pnpm build-wasm
 

docs/split-dsp.md

@@ -199,11 +199,12 @@ pnpm cli-separate-v2 fixtures/sine-2s.wav data/output-split
 - [x] Reuse the Rust DSP implementation and buffers in WASM.
 - [x] Pass waveform/spectrogram inputs and frequency/time outputs across the JS/WASM boundary.
 - [x] Remove `dft.bin` from recognized and required browser model files.
-- [x] Compare browser-generated stems with native split CLI stems in Playwright.
+- [x] Verify browser separation and downloadable stem output in Playwright.
 
 The browser is hard-switched to split graphs; legacy browser model loading is not retained. Native
-CLI legacy support remains available for parity checks. Browser E2E verifies all four downloaded
-stems against native split output with `2e-3` max-absolute and `1e-7` MSE limits.
+CLI legacy support remains available for parity checks. Cross-runtime native/WASM numerical
+alignment is tracked separately in https://github.com/hi-ogawa/demucs-onnx/issues/56 rather than in
+app E2E.
 
 ### 5. Benchmark execution providers
 

packages/app/e2e/separate.spec.ts

@@ -1,34 +1,14 @@
-import { existsSync, readFileSync } from "node:fs";
+import { existsSync } from "node:fs";
 import { resolve } from "node:path";
 import { test, expect } from "@playwright/test";
 
 const MODELS_DIR = resolve(import.meta.dirname, "../../../data/onnx-split");
 const MODEL = resolve(MODELS_DIR, "htdemucs.onnx");
 const FIXTURE = resolve(import.meta.dirname, "../../../fixtures/sine-2s.wav");
-const NATIVE_OUTPUT = resolve(
-  import.meta.dirname,
-  "../../../data/output-split",
-);
-
-function readFloatWav(buffer: Buffer) {
-  const dataOffset = buffer.indexOf("data") + 8;
-  expect(dataOffset).toBeGreaterThan(7);
-  const samples = new Float32Array((buffer.length - dataOffset) / 4);
-  for (let index = 0; index < samples.length; index++) {
-    samples[index] = buffer.readFloatLE(dataOffset + index * 4);
-  }
-  return samples;
-}
 
 test("separates a clip fully client-side", async ({ page }) => {
   expect(existsSync(MODEL), `model missing at ${MODEL}`).toBe(true);
   expect(existsSync(FIXTURE), `fixture missing at ${FIXTURE}`).toBe(true);
-  for (const name of ["drums", "bass", "other", "vocals"]) {
-    expect(
-      existsSync(resolve(NATIVE_OUTPUT, `${name}.wav`)),
-      `native reference missing for ${name}`,
-    ).toBe(true);
-  }
 
   await page.goto("/");
   await page.setInputFiles("#modelFiles", MODEL);
@@ -54,24 +34,6 @@ test("separates a clip fully client-side", async ({ page }) => {
   await expect(stems).toHaveCount(4);
   for (const name of ["drums", "bass", "other", "vocals"]) {
     await expect(page.locator("#stems")).toContainText(name);
-    const row = page.locator("#stems > div").filter({ hasText: name });
-    const downloadPromise = page.waitForEvent("download");
-    await row.getByRole("link", { name: "Download WAV" }).click();
-    const download = await downloadPromise;
-    const browser = readFloatWav(readFileSync((await download.path())!));
-    const native = readFloatWav(
-      readFileSync(resolve(NATIVE_OUTPUT, `${name}.wav`)),
-    );
-    expect(browser.length).toBe(native.length);
-    let maxAbs = 0;
-    let squaredError = 0;
-    for (let index = 0; index < browser.length; index++) {
-      const error = Math.abs(browser[index] - native[index]);
-      maxAbs = Math.max(maxAbs, error);
-      squaredError += error * error;
-    }
-    expect(maxAbs, `${name} max absolute error`).toBeLessThan(2e-3);
-    expect(squaredError / browser.length, `${name} MSE`).toBeLessThan(1e-7);
   }
   await expect(page.locator("#stems audio")).toHaveCount(4);
   await expect(page.locator("#stems a")).toHaveCount(4);