Skip to content

Files Recent Plugin Stored Block Deletion Improvements #1075

Closed
@ata-nas

Description

@ata-nas

Story Form

As a Block Node Developer/User
I want to have a properly working deletion logic that will remove stored blocks from the recents managed root
So that I have reliable recents deletion logic

Technical Notes

  • with the current implementation of the Files Recent Plugin (this issue was created when main was at 5a9f557), the logic that will persist new blocks and the logic that will cleanup old blocks might conflict
  • both of these are called async on separate threads
  • the deletion logic will recursively delete directories (parents) up to the root of the recents
  • but the logic that will persist new blocks relies on the directories that the deletion logic may have deleted
  • if the create directories of the persist logic is executed prior to the deletion logic, exceptions are expected
  • we should improve this logic so that we will not see such issues
  • see org.hiero.block.node.blocks.files.recent.BlocksFilesRecentPlugin#handleVerification and org.hiero.block.node.blocks.files.recent.BlocksFilesRecentPlugin#handlePersisted

Metadata

Metadata

Assignees

Labels

Block NodeIssues/PR related to the Block Node.Block ProviderIssue related to Block ProvidersImprovementCode changes driven by non business requirements

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions