feat(1590): Change signing key to public key for submit key

Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>

Author: matevszm

src/__tests__/integration/topic/create-topic.integration.test.ts

@@ -8,6 +8,7 @@ import '@/core/utils/json-serialize';
 import { STATE_STORAGE_FILE_PATH } from '@/__tests__/test-constants';
 import { setDefaultOperatorForNetwork } from '@/__tests__/utils/network-and-operator-setup';
 import { createCoreApi } from '@/core';
+import { KeyAlgorithm } from '@/core/shared/constants';
 import { topicCreate, topicList } from '@/plugins/topic';
 
 describe('Create Topic Integration Tests', () => {
@@ -20,10 +21,18 @@ describe('Create Topic Integration Tests', () => {
     network = coreApi.network.getCurrentNetwork();
   });
   it('should create a topic and verify with list method', async () => {
+    const operator = coreApi.network.getCurrentOperatorOrThrow();
+    const operatorKeyEntry = coreApi.kms.get(operator.keyRefId)!;
+    const algoPrefix =
+      operatorKeyEntry.keyAlgorithm === KeyAlgorithm.ECDSA
+        ? 'ecdsa:public:'
+        : 'ed25519:public:';
+    const operatorPublicKey = `${algoPrefix}${operatorKeyEntry.publicKey}`;
+
     const createTopicArgs: Record<string, unknown> = {
       memo: 'Test topic',
       adminKey: `${process.env.OPERATOR_ID}:${process.env.OPERATOR_KEY}`,
-      submitKey: `${process.env.OPERATOR_ID}:${process.env.OPERATOR_KEY}`,
+      submitKey: operatorPublicKey,
       name: 'test-topic',
     };
     const createTopicResult = await topicCreate({

src/__tests__/mocks/mocks.ts

@@ -613,6 +613,24 @@ export const makeKeyResolverMock = (
       return { accountId: credential.accountId };
     }
 
+    if (credential?.type === CredentialType.PUBLIC_KEY) {
+      const importResult = options.kms?.importPublicKey
+        ? options.kms.importPublicKey(
+            credential.keyType,
+            credential.publicKey,
+            keyManager,
+            labels || [],
+          )
+        : {
+            keyRefId: 'imported-pub-key-ref-id',
+            publicKey: credential.publicKey,
+          };
+      return {
+        keyRefId: importResult.keyRefId,
+        publicKey: importResult.publicKey,
+      };
+    }
+
     if (credential?.type === CredentialType.ALIAS && options.alias) {
       const network =
         options.network?.getCurrentNetwork() || SupportedNetwork.TESTNET;

src/plugins/topic/__tests__/unit/create.test.ts

@@ -1,7 +1,10 @@
 import type { CoreApi, TransactionResult } from '@/core';
 import type { AliasService } from '@/core/services/alias/alias-service.interface';
 
-import { ED25519_DER_PRIVATE_KEY } from '@/__tests__/mocks/fixtures';
+import {
+  ECDSA_HEX_PUBLIC_KEY,
+  ED25519_DER_PRIVATE_KEY,
+} from '@/__tests__/mocks/fixtures';
 import { createMockTransaction } from '@/__tests__/mocks/hedera-sdk-mocks';
 import {
   makeAliasMock,
@@ -55,12 +58,9 @@ const makeApiMocks = ({
       [ED25519_DER_PRIVATE_KEY]: 'kr_admin',
       '302e020100300506032b6570042204201111111111111111111111111111111111111111111111111111111111111111':
         'kr_admin',
-      '302e020100300506032b6570042204202222222222222222222222222222222222222222222222222222222222222222':
-        'kr_submit',
       '302e020100300506032b6570042204203333333333333333333333333333333333333333333333333333333333333333':
         'kr_33333',
       '302e020100300506032b657004220420admin': 'kr_admin',
-      '302e020100300506032b657004220420submit': 'kr_submit',
       '302e020100300506032b6570042204204444444444444444444444444444444444444444444444444444444444444444':
         'kr_44444',
       '302e020100300506032b6570042204205555555555555555555555555555555555555555555555555555555555555555':
@@ -71,6 +71,15 @@ const makeApiMocks = ({
       publicKey: 'mock-public-key',
     };
   });
+  kms.importPublicKey.mockImplementation((keyType: string, key: string) => {
+    const keyMap: Record<string, string> = {
+      [ECDSA_HEX_PUBLIC_KEY]: 'kr_submit',
+    };
+    return {
+      keyRefId: keyMap[key] || `kr_${key.slice(-5)}`,
+      publicKey: key,
+    };
+  });
   const alias = makeAliasMock();
 
   return { topicTransactions, txSign, txExecute, networkMock, kms, alias };
@@ -144,8 +153,7 @@ describe('topic plugin - create command', () => {
     MockedHelper.mockImplementation(() => ({ saveTopic: saveTopicMock }));
 
     const adminKey = `0.0.123456:${ED25519_DER_PRIVATE_KEY}`;
-    const submitKey =
-      '0.0.789012:302e020100300506032b6570042204202222222222222222222222222222222222222222222222222222222222222222';
+    const submitKey = ECDSA_HEX_PUBLIC_KEY;
 
     const { topicTransactions, txSign, txExecute, networkMock, kms, alias } =
       makeApiMocks({
@@ -195,9 +203,9 @@ describe('topic plugin - create command', () => {
       'local',
       ['topic:admin'],
     );
-    expect(kms.importPrivateKey).toHaveBeenCalledWith(
+    expect(kms.importPublicKey).toHaveBeenCalledWith(
       KeyAlgorithm.ECDSA,
-      '302e020100300506032b6570042204202222222222222222222222222222222222222222222222222222222222222222',
+      ECDSA_HEX_PUBLIC_KEY,
       'local',
       ['topic:submit'],
     );