feat: add mirror node token zod validation

Signed-off-by: rozekmichal <michal.rozek@blockydevs.com>

Author: rozekmichal

src/__tests__/mocks/mocks.ts

@@ -432,7 +432,7 @@ export const makeMirrorMock = (
         ...options.tokenInfo[tokenId],
         total_supply: '1000000',
         max_supply: '1000000',
-        treasury: '0.0.1234',
+        treasury_account_id: '0.0.1234',
         created_timestamp: '1234567890',
         deleted: false,
         default_freeze_status: false,
@@ -448,7 +448,7 @@ export const makeMirrorMock = (
       decimals: '8',
       total_supply: '1000000',
       max_supply: '1000000',
-      treasury: '0.0.1234',
+      treasury_account_id: '0.0.1234',
       created_timestamp: '1234567890',
       deleted: false,
       default_freeze_status: false,

src/core/services/mirrornode/__tests__/unit/hedera-mirrornode-service.test.ts

@@ -21,10 +21,10 @@ import {
   createMockAccountListItemAPIResponse,
   createMockExchangeRateResponse,
   createMockGetAccountsAPIResponse,
+  createMockMirrorNodeTokenByIdJson,
   createMockNftInfo,
   createMockTokenAirdropsResponse,
   createMockTokenBalancesResponse,
-  createMockTokenInfo,
   createMockTopicInfo,
   createMockTopicMessage,
   createMockTopicMessagesAPIResponse,
@@ -827,10 +827,10 @@ describe('HederaMirrornodeServiceDefaultImpl', () => {
   describe('getTokenInfo', () => {
     it('should fetch token info with correct URL', async () => {
       const { service } = setupService();
-      const mockTokenInfo = createMockTokenInfo();
+      const mockJson = createMockMirrorNodeTokenByIdJson();
       (global.fetch as jest.Mock).mockResolvedValue({
         ok: true,
-        json: jest.fn().mockResolvedValue(mockTokenInfo),
+        json: jest.fn().mockResolvedValue(mockJson),
       });
 
       const result = await service.getTokenInfo(TEST_TOKEN_ID);
@@ -840,6 +840,7 @@ describe('HederaMirrornodeServiceDefaultImpl', () => {
       );
       expect(result.token_id).toBe(TEST_TOKEN_ID);
       expect(result.symbol).toBe('TEST');
+      expect(result.treasury_account_id).toBe('0.0.1234');
     });
 
     it('should throw error on HTTP 404', async () => {

src/core/services/mirrornode/__tests__/unit/mocks.ts

@@ -100,6 +100,9 @@ export const createMockTopicMessagesAPIResponse = (
   ...overrides,
 });
 
+/**
+ * Domain `TokenInfo` after `getTokenInfo` (for mocks that bypass HTTP and return a resolved value).
+ */
 export const createMockTokenInfo = (
   overrides: Partial<TokenInfo> = {},
 ): TokenInfo => ({
@@ -110,7 +113,30 @@ export const createMockTokenInfo = (
   total_supply: '1000000000',
   max_supply: '1000000000',
   type: 'NON_FUNGIBLE_UNIQUE',
-  treasury: '0.0.1234',
+  treasury_account_id: '0.0.1234',
+  created_timestamp: '2024-01-01T12:00:00.000Z',
+  deleted: false,
+  default_freeze_status: false,
+  default_kyc_status: false,
+  pause_status: 'UNPAUSED',
+  memo: '',
+  ...overrides,
+});
+
+/**
+ * Raw JSON body for GET /api/v1/tokens/{id} (Mirror Node). Use with `fetch` mocks.
+ */
+export const createMockMirrorNodeTokenByIdJson = (
+  overrides: Record<string, unknown> = {},
+): Record<string, unknown> => ({
+  token_id: '0.0.2000',
+  symbol: 'TEST',
+  name: 'Test Token',
+  decimals: '6',
+  total_supply: '1000000000',
+  max_supply: '1000000000',
+  type: 'NON_FUNGIBLE_UNIQUE',
+  treasury_account_id: '0.0.1234',
   created_timestamp: '2024-01-01T12:00:00.000Z',
   deleted: false,
   default_freeze_status: false,

src/core/services/mirrornode/hedera-mirrornode-service.ts

@@ -26,10 +26,17 @@ import type {
   TransactionDetailsResponse,
 } from './types';
 
-import { ConfigurationError, NetworkError, NotFoundError } from '@/core/errors';
+import {
+  CliError,
+  ConfigurationError,
+  NetworkError,
+  NotFoundError,
+} from '@/core/errors';
 import { KeyAlgorithm } from '@/core/shared/constants';
+import { parseWithSchema } from '@/core/shared/validation/parse-with-schema.zod';
 import { handleMirrorNodeErrorResponse } from '@/core/utils/handle-mirror-node-error-response';
 
+import { TokenInfoSchema } from './schema';
 import { NetworkToBaseUrl } from './types';
 
 export class HederaMirrornodeServiceDefaultImpl implements HederaMirrornodeService {
@@ -324,10 +331,13 @@ export class HederaMirrornodeServiceDefaultImpl implements HederaMirrornodeServi
         );
       }
 
-      return (await response.json()) as TokenInfo;
+      return parseWithSchema(
+        TokenInfoSchema,
+        await response.json(),
+        `Mirror Node GET /tokens/${tokenId}`,
+      );
     } catch (error) {
-      if (error instanceof NotFoundError || error instanceof NetworkError)
-        throw error;
+      if (error instanceof CliError) throw error;
       throw new NetworkError(`Failed to fetch token info for ${tokenId}`, {
         cause: error,
         recoverable: true,

src/core/services/mirrornode/schema.ts

@@ -0,0 +1,34 @@
+import type { TokenInfo } from './types';
+
+import { z } from 'zod';
+
+const optionalMirrorKey = z
+  .object({
+    _type: z.string(),
+    key: z.string(),
+  })
+  .optional();
+
+export const TokenInfoSchema: z.ZodType<TokenInfo> = z.object({
+  token_id: z.string(),
+  symbol: z.string(),
+  name: z.string(),
+  decimals: z.string(),
+  total_supply: z.string(),
+  max_supply: z.string(),
+  type: z.string(),
+  treasury_account_id: z.string(),
+  admin_key: optionalMirrorKey,
+  kyc_key: optionalMirrorKey,
+  freeze_key: optionalMirrorKey,
+  wipe_key: optionalMirrorKey,
+  supply_key: optionalMirrorKey,
+  fee_schedule_key: optionalMirrorKey,
+  pause_key: optionalMirrorKey,
+  created_timestamp: z.string(),
+  deleted: z.boolean(),
+  default_freeze_status: z.boolean(),
+  default_kyc_status: z.boolean(),
+  pause_status: z.string(),
+  memo: z.string(),
+});

src/core/services/mirrornode/types.ts

@@ -69,7 +69,7 @@ export interface TokenInfo {
   total_supply: string;
   max_supply: string;
   type: string;
-  treasury: string;
+  treasury_account_id: string;
   admin_key?: {
     _type: string;
     key: string;

src/core/shared/validation/parse-with-schema.zod.ts

@@ -0,0 +1,18 @@
+import type { z } from 'zod';
+
+import { ValidationError } from '@/core/errors';
+
+export function parseWithSchema<T>(
+  schema: z.ZodType<T>,
+  data: unknown,
+  context: string,
+): T {
+  const result = schema.safeParse(data);
+  if (!result.success) {
+    throw new ValidationError(`Invalid response (${context})`, {
+      cause: result.error,
+      context: { issues: result.error.issues },
+    });
+  }
+  return result.data;
+}

src/plugins/token/__tests__/unit/import.test.ts

@@ -46,7 +46,7 @@ describe('token plugin - import command (ADR-007)', () => {
       decimals: '6',
       total_supply: '1000000',
       max_supply: '1000000',
-      treasury: '0.0.100',
+      treasury_account_id: '0.0.100',
       memo: 'Imported token memo',
       admin_key: { _type: 'ED25519', key: 'admin-key-123' },
       supply_key: { _type: 'ED25519', key: 'supply-key-456' },

src/plugins/token/commands/import/handler.ts

@@ -59,7 +59,7 @@ export class TokenImportCommand implements Command {
       tokenId: validArgs.tokenId,
       name: tokenInfo.name,
       symbol: tokenInfo.symbol,
-      treasuryId: tokenInfo.treasury,
+      treasuryId: tokenInfo.treasury_account_id,
       adminPublicKey: tokenInfo.admin_key?.key,
       supplyPublicKey: tokenInfo.supply_key?.key,
       wipePublicKey: tokenInfo.wipe_key?.key,

src/plugins/token/utils/nft-build-output.ts

@@ -66,7 +66,7 @@ export function buildOutput(
     totalSupply: tokenInfo.total_supply,
     maxSupply: tokenInfo.max_supply,
     supplyType,
-    treasury: tokenInfo.treasury || undefined,
+    treasury: tokenInfo.treasury_account_id || undefined,
     memo: tokenInfo.memo || undefined,
     createdTimestamp: formatHederaTimestamp(tokenInfo.created_timestamp),
     adminKey: tokenInfo.admin_key?.key || null,