Skip to content

Commit e037658

Browse files
Resolve PR comments
Signed-off-by: Ivan Kavaldzhiev <ivankavaldzhiev@gmail.com>
1 parent 6f237a5 commit e037658

3 files changed

Lines changed: 4 additions & 11 deletions

File tree

.github/workflows/gradle.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,6 @@ jobs:
8989
if: ${{ matrix.schema == 'v1' && matrix.project != 'test' && always() && (github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository) }}
9090
run: ./gradlew :${{ matrix.project }}:uploadCoverage
9191

92-
# - name: Build and test web3 with monolithic code
93-
# env:
94-
# HIERO_MIRROR_WEB3_EVM_MODULARIZEDSERVICES: "false"
95-
# HIERO_MIRROR_WEB3_EVM_OVERRIDEPAYERBALANCEVALIDATION: "false"
96-
# if: ${{ matrix.project == 'web3' && matrix.schema == 'v1'}}
97-
# run: ./gradlew :${{ matrix.project }}:build
98-
9992
coverage:
10093
if: github.event_name == 'push' || (github.event.pull_request.head.repo.full_name == github.repository)
10194
name: Upload coverage

build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ dependencies {
5050
api("com.graphql-java-generator:graphql-java-client-runtime:3.0.1")
5151
api("com.graphql-java:graphql-java-extended-scalars:24.0")
5252
api("com.graphql-java:graphql-java-extended-validation:24.0")
53-
api("com.hedera.hashgraph:app:0.67.1")
53+
api("com.hedera.hashgraph:app:0.67.2")
5454
api("com.hedera.evm:hedera-evm:0.54.2")
55-
api("com.hedera.hashgraph:hedera-protobuf-java-api:0.67.0")
55+
api("com.hedera.hashgraph:hedera-protobuf-java-api:0.67.2")
5656
api("com.hedera.hashgraph:sdk:2.64.0")
5757
api("com.ongres.scram:client:2.1")
5858
api("com.salesforce.servicelibs:reactor-grpc-stub:$reactorGrpcVersion")

web3/src/test/java/org/hiero/mirror/web3/evm/store/contract/HederaEvmWorldStateTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ void returnsNull() {
167167
assertThat(subject.get(address)).isNull();
168168
}
169169

170-
// There are uncompatible changes between hedera-evm and latest besu version
170+
// There are incompatible changes between hedera-evm and latest besu version
171171
@Test
172172
@Disabled
173173
void returnsWorldStateAccount() {
@@ -181,7 +181,7 @@ void returnsWorldStateAccount() {
181181
assertThat(account.hasCode()).isFalse();
182182
}
183183

184-
// There are uncompatible changes between hedera-evm and latest besu version
184+
// There are incompatible changes between hedera-evm and latest besu version
185185
@Test
186186
@Disabled
187187
void returnsHederaEvmWorldStateTokenAccount() {

0 commit comments

Comments
 (0)