fix(Experimental): Cross group validation#1281
fix(Experimental): Cross group validation#1281ddeskov-limechain wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: Dian Deskov <dian.deskov@limechain.tech>
|
Hey @ddeskov-limechain 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ❌ Issue Link -- This PR is not linked to any issue. Please reference an issue using a closing keyword (e.g. ⏳ All checks must pass before this PR can be reviewed. You've got this! |
|
@rwalworth Could you ignore this PR for now we are experimenting with some tooling. |
|
@gsstoykov @ddeskov-limechain just checking in here, would you like to keep this PR open or can we close? |
|
Not relevant. |
Add explicit chunk-count validation in
from_bytes()Summary
Transaction::from_bytes()that rejects multi-groupTransactionListpayloads for non-chunked transaction typesFileAppendTransactionandTopicMessageSubmitTransactionlegitimately use multiple transaction ID groups; all other types now fail early with a clear error messageTest plan
cargo test cross_group_forgery-- all 5 tests passcargo test -p hiero-sdk --lib-- full suite (956 tests), 0 failures