-
Notifications
You must be signed in to change notification settings - Fork 73
[Good First Issue]: Update JSDoc to reflect updated validation logic #1308
Copy link
Copy link
Labels
kind: documentationImprovements or additions to READMEs, guides, API docs, or code commentsImprovements or additions to READMEs, guides, API docs, or code commentspriority: lowNon-urgent tasks, nice-to-have improvements, or minor issuesNon-urgent tasks, nice-to-have improvements, or minor issuesscope: ciRelated to GitHub Actions or CI/CDRelated to GitHub Actions or CI/CDskill: good first issueSimple, well-scoped tasks ideal for someone new to the repository or open sourceSimple, well-scoped tasks ideal for someone new to the repository or open source
Milestone
Metadata
Metadata
Assignees
Labels
kind: documentationImprovements or additions to READMEs, guides, API docs, or code commentsImprovements or additions to READMEs, guides, API docs, or code commentspriority: lowNon-urgent tasks, nice-to-have improvements, or minor issuesNon-urgent tasks, nice-to-have improvements, or minor issuesscope: ciRelated to GitHub Actions or CI/CDRelated to GitHub Actions or CI/CDskill: good first issueSimple, well-scoped tasks ideal for someone new to the repository or open sourceSimple, well-scoped tasks ideal for someone new to the repository or open source
Type
Fields
Give feedbackNo fields configured for Task.
🆕🐥 First-Time Friendly
This issue is especially welcoming for people who are new to contributing to the Hiero C++ SDK.
We know that opening your first pull request can feel like a big step.
Issues labeled Good First Issue are designed to make that experience easier, clearer, and more comfortable.
No prior knowledge of Hiero, Hedera, or distributed ledger technology is required.
Just a basic familiarity with C++ and Git is more than enough to get started.
👾 Description of the Issue
The file:
.github/scripts/helpers/validation.jsThe logic for auto-assignment of PRs was recently updated to allow GitHub bot accounts - suffixed with [bot], but the documentation has lagged behind the changes.
Make changes to the JSDoc to reflect the update.
💡 Proposed Solution
Update the comments in
.github/scripts/helpers/validation.jsin the isSafeSearchToken() method to look more like thisThe changes should:
Not modify any existing logic
Not change behavior or public APIs
Be limited to comments only
Improve readability for new contributors
👩💻 Implementation Steps (End-to-End)
To complete this change:
.github/scripts/helpers/validation.jsisSafeSearchToken()✅ Acceptance Criteria
To merge a pull request for this issue:
📋 Step-by-Step Contribution Guide
To help your first contribution go as smoothly as possible, we recommend following these steps:
/assignto request the issueREADME.md-s -SRead Workflow Guide for step-by-step workflow guidance.
Read README.md for setup instructions.
❗ Pull requests cannot be merged without
Sandssigned commits.See the Signing Guide.
🤔 Additional Information
If you need help, reach out to the @hiero-ledger/hiero-sdk-good-first-issue-support team.
You can also join our community on Discord:
Hiero-SDK-C++
Maintainers are happy to help first-time contributors succeed!