-
Notifications
You must be signed in to change notification settings - Fork 152
Open
Labels
beginnerAchievable by a fairly new comer that has already completed a couple of good first issuesAchievable by a fairly new comer that has already completed a couple of good first issuesjavascriptUses Javascript programming languageUses Javascript programming language
Description
Beginner Friendly
This issue is intended for contributors who are new to the Hiero Python SDK.
Problem Description
The \�ot-pr-missing-linked-issue\ workflow currently uses a strict regex that only matches \Fixes. It fails to recognize standard GitHub closing keywords like \Closes\ and \Resolves.
- File: .github/scripts/bot-pr-missing-linked-issue.js\
- Current Regex: /\bFixes\s*:?\s*(#\d+)(\s*,\s*#\d+)*/i\
This causes the bot to complain even when a PR correctly uses \Closes #123.
Expected Solution
Update the regex to support all standard GitHub closing keywords: \Fixes, \Closes, and \Resolves\ (case-insensitive).
Implementation Steps
- Locate .github/scripts/bot-pr-missing-linked-issue.js.
- Find the line defining \const regex.
- Update the regex to: /\b(Fixes|Closes|Resolves)\s*:?\s*(#\d+)(\s*,\s*#\d+)*/i\
Acceptance Criteria
- The bot should recognize \Fixes chore: [StepSecurity] Apply security best practices #123.
- The bot should recognize \Closes chore: [StepSecurity] Apply security best practices #123.
- The bot should recognize \Resolves chore: [StepSecurity] Apply security best practices #123.
Additional Context
exploreriiiexploreriii
Metadata
Metadata
Assignees
Labels
beginnerAchievable by a fairly new comer that has already completed a couple of good first issuesAchievable by a fairly new comer that has already completed a couple of good first issuesjavascriptUses Javascript programming languageUses Javascript programming language