Code cleaning

Author: hiett

README.md

@@ -2,7 +2,7 @@
 A Redis connection pooler for serverless applications. This allows your serverless functions to talk to Redis via HTTP,
 while also not having to worry about the Redis max connection limits.
 
-The idea is you host this alongside your Redis server, so minimise latency. The serverless functions can then talk to 
+The idea is you host this alongside your Redis server, to minimise latency. Your serverless functions can then talk to 
 this via HTTP.
 
 ## Features

config/config.exs

@@ -2,7 +2,6 @@ import Config
 
 config :srh,
        mode: "file",
-       file_path: "srh-config/tokens.json",
-       file_hard_reload: false
+       file_path: "srh-config/tokens.json"
 
 import_config "#{config_env()}.exs"

config/dev.exs

@@ -1,4 +1 @@
 import Config
-
-config :srh,
-       file_hard_reload: true

lib/srh/auth/token_resolver.ex

@@ -3,7 +3,6 @@ defmodule Srh.Auth.TokenResolver do
 
   @mode Application.fetch_env!(:srh, :mode)
   @file_path Application.fetch_env!(:srh, :file_path)
-  @file_hard_reload Application.fetch_env!(:srh, :file_hard_reload)
 
   @ets_table_name :srh_token_resolver
 
@@ -74,7 +73,7 @@ defmodule Srh.Auth.TokenResolver do
     end
   end
 
-  defp do_resolve("redis", token) do
+  defp do_resolve("redis", _token) do
     {
       :ok,
       # This is done to replicate what will eventually be API endpoints, so they keys are not atoms

lib/srh/http/base_router.ex

@@ -49,7 +49,7 @@ defmodule Srh.Http.BaseRouter do
         {:malformed_data, message} -> %{code: 400, message: message, json: false}
         {:not_authorized, message} -> %{code: 401, message: message, json: false}
         {:server_error, _} -> %{code: 500, message: "An error occurred internally", json: false}
-        other ->
+        _ ->
           %{code: 500, message: "An error occurred internally", json: false}
       end
 

lib/srh/http/command_handler.ex

@@ -38,7 +38,9 @@ defmodule Srh.Http.CommandHandler do
     end
   end
 
-  defp dispatch_command_array([current | rest], connection_info, responses \\ []) do
+  defp dispatch_command_array(_arr, _connection_info, responses \\ [])
+  
+  defp dispatch_command_array([current | rest], connection_info, responses) do
     updated_responses = case dispatch_command(current, connection_info) do
       {:ok, result_map} ->
         [result_map | responses]
@@ -50,7 +52,7 @@ defmodule Srh.Http.CommandHandler do
     dispatch_command_array(rest, connection_info, updated_responses)
   end
 
-  defp dispatch_command_array([], connection_info, responses) do
+  defp dispatch_command_array([], _connection_info, responses) do
     # The responses will be in reverse order, as we're adding them to the list with the faster method of putting them at head.
     {:ok, Enum.reverse(responses)}
   end

lib/srh/http/request_validator.ex

@@ -1,7 +1,7 @@
 defmodule Srh.Http.RequestValidator do
   def validate_redis_body(%{"_json" => command_array}) when is_list(command_array), do: {:ok, command_array}
 
-  def validate_redis_body(payload),
+  def validate_redis_body(_),
       do: {:error, "Invalid command array. Expected a string array at root of the command and its arguments."}
 
   def validate_pipeline_redis_body(%{"_json" => array_of_command_arrays}) when is_list(array_of_command_arrays) do
@@ -20,7 +20,7 @@ defmodule Srh.Http.RequestValidator do
 
   defp do_validate_pipeline_item(item) when is_list(item), do: :ok
 
-  defp do_validate_pipeline_item(item), do: :error
+  defp do_validate_pipeline_item(_), do: :error
 
   def validate_bearer_header(header_value_array) when is_list(header_value_array) do
     do_validate_bearer_header(header_value_array)

lib/srh/redis/client_worker.ex

@@ -32,7 +32,7 @@ defmodule Srh.Redis.ClientWorker do
     end
   end
 
-  def handle_call(msg, _from, state) do
+  def handle_call(_msg, _from, state) do
     {:reply, :ok, state}
   end