sunspider/date-format-tofte not working

[maximecb]

The sunspider/date-format-tofte benchmark seems to be using very high amounts of memory, possibly due to string allocation. I stopped it after it had expanded the Higgs heap to 4GB on my system, which seems completely abnormal (these benchmarks are meant to run in a browser, on a computer from 1999).

[bFraley]

I think there's a hiccup either right at the beginning of the file, the arrayExists loop, or near the end using keyword 'while'.

Does arrayExists ever return false ?
Lines 1 - 8

 function arrayExists(array, x) {
  /* BEGIN LOOP */
    for (var i = 0; i < array.length; i++) {
        if (array[i] == x) return true;
    }
  /* END LOOP */
    return false;
}

This is some cryptic hackmanship here. Uses while and uses arrayExists(switches,ia[ij]))
as an arg to a nested if. Again, does arrayExists ever return false ?

Additionally is: eval(ia[ij] + "()"

Lines: 274 - 294

    var ia = input.split("");
    var ij = 0;
  /* BEGIN LOOP */
    while (ia[ij]) {
        if (ia[ij] == "\\") {
            // this is our way of allowing users to escape stuff
            ia.splice(ij,1);
        } else {
            if (arrayExists(switches,ia[ij])) {
                ia[ij] = eval(ia[ij] + "()");
            }
        }
        ij++;
    }
  /* END LOOP */
    // reset time, back to what it was
    if (prevTime) {
        self.setTime(prevTime);
    }
    return ia.join("");
}    

[maximecb]

The problem might just be the eval. It doesn't support capturing local variables at the moment.

[mollymorphic]

Note that PR #125 fixes the memory consumption issue. The benchmark still fails however due to the fact that it relies on eval'd code being able to access the current scope.