Run test suite on browsers

[frangio]

We're currently running the test suite in Node.js only. We should also run it in the browser.

[ajb413]

That would be great! Can confirm that there is a regex error for this plugin in safari but not other browsers.

SyntaxError: Invalid regular expression: invalid group specifier name

[joshgoebel]

What version of Safari and what version of Mac OS?

[ajb413]

Safari Version 15.4 (17613.1.17.1.13)
Monterey 12.3.1

[joshgoebel]

@ajb413 Can you get us as stack trace of the error?

[ajb413]

Breaks on line 1172 of a fresh common js build of Highlight.js v11.5.0 (git: 6fc781508b). I added a log line so you can see the bad input of value. I pasted the common js build into my min file so don't be confused by that in the screenshot.

-?((?<!\$)\b0[xX]([a-fA-F0-9]_?)*[a-fA-F0-9]|((?<!\$)\b[1-9](_?\d)*(\.((\d_?)*\d)?)?|\.\d(_?\d)*)([eE][-+]?\d(_?\d)*)?|(?<!\$)\b0)(?!\w|\$)

Edit: Looks like that comes from this line here: https://github.com/highlightjs/highlightjs-solidity/blob/master/src/common.js#L27

Edit: Seeing same error on v10.7.3 and v10.4.1

[joshgoebel]

That's trying to put together a regex with negative look-behinds... but the library has a check for that, so I'm not sure what is going on there.

[ajb413]

I had some time to dig on this. I got my minified version (@2.0.5/dist/solidity.min.js) from jsdelivr.com. It looks like there was a build issue. You can see that file here.

The negative look behind check is simply omitted from the minified build.

You can see it is the first function at the top, after the "use strict" in the minified file.

If you change the try/catch in the minified file to this:

function e(){try{new RegExp('(?<!.)');return!0
}catch(e){return!1}}

then that check actually happens, and that Safari error goes away, and the package works properly

[joshgoebel]

Perhaps minified build needs different minifier arguments to not compile out the check?