logical references are not recognized if resource type information is missing

[wetret]

Logical references as this one:

"valueReference": {
    "identifier": {
        "system": "http://www.netzwerk-universitaetsmedizin.de/sid/dic-pseudonym",
        "value": "source/original"
    }
}

are not recognized as logical references because the resource type information is missing. Valid logical references have the form:

"valueReference": {
    "type": "Patient",
    "identifier": {
        "system": "http://www.netzwerk-universitaetsmedizin.de/sid/dic-pseudonym",
        "value": "source/original"
     }
}

This is caused because of the following code:

highmed-dsf/dsf-fhir/dsf-fhir-rest-adapter/src/main/java/org/highmed/dsf/fhir/service/ResourceReference.java

Line 275 in 769747a

else if (reference.hasType() && reference.hasIdentifier() && reference.getIdentifier().hasSystem()

We could either enforce resource type information and add a debug log message before returning ResourceReference.UNKNOWN or we could remove the type check from the code above and change the code that checks if logical references are resolvable:

highmed-dsf/dsf-fhir/dsf-fhir-server/src/main/java/org/highmed/dsf/fhir/service/ReferenceResolverImpl.java

Lines 96 to 107 in 769747a

	private boolean logicalReferenceCanBeCheckedAndResolved(ResourceReference reference, Connection connection)
	{
	ReferenceType type = reference.getType(serverBase);
	if (!ReferenceType.LOGICAL.equals(type))
	throw new IllegalArgumentException("Not a logical reference");
	NamingSystemDao namingSystemDao = daoProvider.getNamingSystemDao();
	return exceptionHandler
	.handleSqlException(() -> namingSystemDao.existsWithUniqueIdUriEntryResolvable(connection,
	reference.getReference().getIdentifier().getSystem()));
	}