Skip to content

Commit 2d5c3be

Browse files
authored
fix: Adjust some status codes returned by API when delete operation fails (#139)
1 parent b365c06 commit 2d5c3be

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/apiserver/pkg/registry/file_rest.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -473,11 +473,11 @@ func (f *fileREST) Delete(
473473

474474
oldObj, err := f.Get(ctx, name, nil)
475475
if err != nil {
476-
return nil, false, apierrors.NewInternalError(err)
476+
return nil, false, err
477477
}
478478
if deleteValidation != nil {
479479
if err := deleteValidation(ctx, oldObj); err != nil {
480-
return nil, false, apierrors.NewInternalError(err)
480+
return nil, false, apierrors.NewBadRequest(err.Error())
481481
}
482482
}
483483

src/apiserver/pkg/registry/nacos_rest.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,11 @@ func (n *nacosREST) Delete(
374374

375375
oldObj, err := n.Get(ctx, name, nil)
376376
if err != nil {
377-
return nil, false, apierrors.NewInternalError(err)
377+
return nil, false, err
378378
}
379379
if deleteValidation != nil {
380380
if err := deleteValidation(ctx, oldObj); err != nil {
381-
return nil, false, apierrors.NewInternalError(err)
381+
return nil, false, apierrors.NewBadRequest(err.Error())
382382
}
383383
}
384384

0 commit comments

Comments
 (0)