Commit 73bab41
authored
fix: reuse PLUGIN_REGISTRY for IMAGE_REPO construction (#240)
Ensure IMAGE_REPO and PLUGIN_REGISTRY use the same registry domain
by constructing IMAGE_REPO from PLUGIN_REGISTRY when not explicitly set.
Before:
- IMAGE_REPO and PLUGIN_REGISTRY were set independently
- Could potentially use different registries
- Duplicated registry domain logic
After:
- PLUGIN_REGISTRY is detected first (via detectPluginRegistry)
- IMAGE_REPO is built from PLUGIN_REGISTRY: ${PLUGIN_REGISTRY}/higress/all-in-one
- Ensures both use the same geographically optimal registry
Behavior:
1. User sets IMAGE_REPO explicitly → use user's value (backward compatible)
2. User doesn't set IMAGE_REPO → construct from PLUGIN_REGISTRY (DRY)
Benefits:
- Single source of truth for registry domain (PLUGIN_REGISTRY)
- No duplicate registry selection logic
- Container image and plugins always use same registry
- Maintains backward compatibility with explicit IMAGE_REPO1 parent 123aa03 commit 73bab41
1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
562 | 562 | | |
563 | 563 | | |
564 | 564 | | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
| 565 | + | |
569 | 566 | | |
570 | 567 | | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
571 | 574 | | |
572 | 575 | | |
573 | 576 | | |
| |||
0 commit comments