test: fix json parse error

Author: janniks

package-lock.json

@@ -890,9 +890,8 @@ async function contractFunctionCall(_network: CLINetworkAdapter, args: string[])
 
   try {
     const response = await broadcastTransaction({ transaction: tx, network });
-    if ('error' in response) {
-      return JSONStringify(response);
-    }
+    if (response.hasOwnProperty('error')) return JSONStringify(response);
+
     return JSONStringify({
       txid: `0x${tx.txid()}`,
       transaction: generateExplorerTxPageUrl(tx.txid(), network),

packages/cli/src/cli.ts

@@ -115,7 +115,7 @@ describe('Contract function call', () => {
     const txid = '0x6c764e276b500babdac6cec159667f4b68938d31eee82419473a418222af7d5d';
     fetchMock.once(JSON.stringify(TEST_ABI)).once(txid);
 
-    const result = await contractFunctionCall(testnetNetwork, args);
+    const result = JSON.parse(await contractFunctionCall(testnetNetwork, args));
 
     expect(result.txid).toEqual(txid);
   });
@@ -136,7 +136,7 @@ describe('Contract function call', () => {
     const txid = '0x97f41dfa44a5833acd9ca30ffe31d7137623c0e31a5c6467daeed8e61a03f51c';
     fetchMock.once(JSON.stringify(TEST_ABI)).once(txid);
 
-    const result = await contractFunctionCall(testnetNetwork, args);
+    const result = JSON.parse(await contractFunctionCall(testnetNetwork, args));
 
     expect(result.txid).toEqual(txid);
   });
@@ -157,7 +157,7 @@ describe('Contract function call', () => {
     const txid = '0x5fc468f21345c5ecaf1c007fce9630d9a79ec1945ed8652cc3c42fb542e35fe2';
     fetchMock.once(JSON.stringify(TEST_ABI)).once(txid);
 
-    const result = await contractFunctionCall(testnetNetwork, args);
+    const result = JSON.parse(await contractFunctionCall(testnetNetwork, args));
 
     expect(result.txid).toEqual(txid);
   });
@@ -182,7 +182,7 @@ describe('Contract function call', () => {
     const txid = '0x94b1cfab79555b8c6725f19e4fcd6268934d905578a3e8ef7a1e542b931d3676';
     fetchMock.once(JSON.stringify(TEST_ABI)).once(txid);
 
-    const result = await contractFunctionCall(testnetNetwork, args);
+    const result = JSON.parse(await contractFunctionCall(testnetNetwork, args));
 
     expect(result.txid).toEqual(txid);
   });
@@ -205,7 +205,7 @@ describe('Contract function call', () => {
     const txid = '0x6b6cd5bfb44c46a68090f0c5f659e9cc02518eafab67b0b740e1e77a55bbf284';
     fetchMock.once(JSON.stringify(TEST_ABI)).once(txid);
 
-    const result = await contractFunctionCall(testnetNetwork, args);
+    const result = JSON.parse(await contractFunctionCall(testnetNetwork, args));
 
     expect(result.txid).toEqual(txid);
   });

packages/cli/tests/cli.test.ts

@@ -127,7 +127,6 @@ describe('Contract Function Call with Direct Arguments', () => {
     // Validate the transaction
     expect(capturedTxHex).toBeTruthy();
     expect(typeof capturedTxHex).toBe('string');
-    expect(capturedTxHex.length).toBeGreaterThan(100); // Reasonable transaction length
 
     // Compare the captured transaction hex with our expected transaction
     expect(capturedTxHex).toEqual(expectedTxHex);