Merge pull request #960

* chore(32824): add dispatch to the workflow triggers

* chore(32824): fix README.md

* chore(32824): fix sonar-qube project configuration

* chore(32824): test config

* chore(32824): add verbose

* chore(31411): debug

* chore(32824): remove secrets out of conditional job

* chore(32824): remove secrets out of conditional job

* chore(31411): fix working-directory

* chore(32824): remove deprecated steps

* chore(32824): test secrets

* chore(31411): add basic sonarqube config

* chore(32824): test path

* chore(32824): messing with env

* Revert "chore(32824): messing with env"

* chore(32824): remove from CI check

* chore(32824): remove from CI check

* chore(32824): remove from CI check

* Adde secrets as input parameters

* chore(32824): cleaning up

* chore(32662): merge jobs

* chore(32662): try reportPaths

* chore(32662): try reportPaths

* chore(32662): try reportPaths

* chore(32662): try reportPaths

* chore(32662): try reportPaths

* chore(32662): add combined code cov directory

* chore(32662): try check out

* chore(32662): restore reportPaths

* chore(32824): fix checkout

* chore(32662): test run

* chore(32662): test run

* chore(32662): fix options

Author: vanch3d

.github/workflows/check-frontend.yml

@@ -4,25 +4,18 @@
 name: Frontend - React Testing Pyramid
 
 on:
+  workflow_dispatch:
   workflow_call:
-#  push:
-#    paths:
-#      - hivemq-edge-frontend/**
-#      - .github/workflows/frontend-cli.yml
-#      - .github/actions/setup_node/action.yml
-env:
-  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    secrets:
+      SONAR_TOKEN:
+        required: false
+      PERCY_TOKEN:
+        required: false
 
 defaults:
   run:
     working-directory: ./hivemq-edge-frontend/
 
-## Cancel previous workflow on a follow-up push event
-## https://stackoverflow.com/a/72408109
-#concurrency:
-#  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-#  cancel-in-progress: true
-
 jobs:
   lint:
     runs-on: ubuntu-latest
@@ -163,32 +156,33 @@ jobs:
           if-no-files-found: ignore
           retention-days: 1
 
-  combine_code_coverage:
-    runs-on: ubuntu-latest
+  sonarqube:
+    name: SonarQube
     needs: [ cypress_matrix, unit_tests ]
     # Should we collect partial test results and combine them ?
     if: success() || failure()
+    runs-on: ubuntu-latest
     steps:
-      - name: Download All LCOV Artifacts
+      - name: 👓 Checkout repository
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+      - name: Download all LCOV Artifacts
         uses: actions/download-artifact@v4
         with:
           path: hivemq-edge-frontend/coverage-combined
           pattern: lcov-*
           merge-multiple: false
-      # Should contain the lcov.info summary, in subdirectory named from the tasks
-      - run: ls -R ./coverage-combined
-
-  sonarqube:
-    name: SonarQube
-    needs: [ combine_code_coverage ]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+      - name: Verify LCOV Artifacts
+        # Should contain the lcov.info summary, in subdirectory named from the tasks
+        run: |
+          ls -R ./coverage-combined
+          ls -R **/**/*.info
       - name: SonarQube Scan
         uses: SonarSource/sonarqube-scan-action@v5
         with:
           projectBaseDir: hivemq-edge-frontend
+          args: >
+            -Dsonar.verbose=false
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/check.yml

@@ -3,6 +3,12 @@ name: CI Check
 on:
   push:
 
+env:
+  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  # For frontend usage; secrets cannot be accessed in a conditional job
+  SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
@@ -42,6 +48,9 @@ jobs:
     needs: check-for-changes
     uses: ./.github/workflows/check-frontend.yml
     if: needs.check-for-changes.outputs.frontend-changed == 'true'
+    secrets:
+      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+      PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
 
   check-backend:
     needs: check-for-changes

hivemq-edge-frontend/README.md

@@ -140,3 +140,5 @@ Together. they contain - and enforce - parts of the testing pyramid for frontend
 ### Percy - Visual testing
 
 ### Lighthouse - Performance testing
+
+### SonarQube Cloud

hivemq-edge-frontend/coverage-combined/README.md

@@ -0,0 +1 @@
+#### Combined code coverage

hivemq-edge-frontend/sonar-project.properties

@@ -1,9 +1,9 @@
-sonar.projectKey=vanch3d_hivemq-edge
-sonar.organization=vanch3d
+sonar.projectKey= hivemq_hivemq-edge
+sonar.organization=hivemq
 
 
 # This is the name and version displayed in the SonarCloud UI.
-sonar.projectName=vanch3d_hivemq-edge
+sonar.projectName=hivemq_hivemq-edge
 sonar.projectVersion=1.0