Skip to content

Commit 0a90c38

Browse files
committed
fix: enhance Voucher API to include unlimited field and improve parameter casting
1 parent a057643 commit 0a90c38

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

src/budy/controllers/api/voucher.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ def create_value(self):
6969
start = object.get("start", None)
7070
expiration = object.get("expiration", None)
7171
meta = object.get("meta", {})
72+
key = self.field("key", key, cast=str)
73+
amount = self.field("amount", amount, cast=float)
74+
currency = self.field("currency", currency, cast=str)
75+
usage_limit = self.field("usage_limit", usage_limit, cast=int)
76+
unlimited = self.field("unlimited", unlimited, cast=bool)
77+
start = self.field("start", start, cast=int)
78+
expiration = self.field("expiration", expiration, cast=int)
79+
meta = self.field("meta", meta, cast=dict)
7280
voucher = budy.Voucher.create_value_s(
7381
key, amount, currency, usage_limit, unlimited, start, expiration, meta
7482
)
@@ -85,6 +93,14 @@ def create_percentage(self):
8593
start = object.get("start", None)
8694
expiration = object.get("expiration", None)
8795
meta = object.get("meta", {})
96+
unlimited = object.get("unlimited", None)
97+
key = self.field("key", key, cast=str)
98+
percentage = self.field("percentage", percentage, cast=float)
99+
usage_limit = self.field("usage_limit", usage_limit, cast=int)
100+
start = self.field("start", start, cast=int)
101+
expiration = self.field("expiration", expiration, cast=int)
102+
meta = self.field("meta", meta, cast=dict)
103+
unlimited = self.field("unlimited", unlimited, cast=bool)
88104
voucher = budy.Voucher.create_percentage_s(
89105
key, percentage, usage_limit, start, expiration, meta
90106
)

src/budy/models/voucher_use.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class VoucherUse(base.BudyBase):
6363
justification = appier.field(
6464
type=str,
6565
safe=True,
66-
observations="""Justification or reason for the usage of the voucher,m
66+
observations="""Justification or reason for the usage of the voucher,
6767
may contain external ID references""",
6868
)
6969

0 commit comments

Comments
 (0)