Skip to content

Commit 55e2355

Browse files
committed
deletion of derived class requires virtual dtor
1 parent 970b0ca commit 55e2355

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

src/OpenCOVER/audio/Player.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ Player::Player(const Listener *listener, bool isMaster)
106106
{
107107
}
108108

109+
Player::~Player() = default;
110+
109111
void Player::update()
110112
{
111113
for (auto &source : sources)
@@ -133,7 +135,7 @@ Player *Player::createPlayer(Listener *listener, const std::string &type, bool i
133135
else if (boost::iequals(type, "openal"))
134136
{
135137
return new PlayerOpenAL(listener,isMa);
136-
138+
137139
}
138140
else if (boost::iequals(type, "none"))
139141
{

src/OpenCOVER/audio/Player.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ class COVRAUDIOEXPORT Player
7171

7272
public:
7373
Player(const Listener *listener, bool isMaster);
74+
virtual ~Player();
7475
virtual void update();
7576
virtual std::unique_ptr<Source> makeSource(const Audio *);
7677

0 commit comments

Comments
 (0)